Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert woo.com → woocommerce.com in URLs #2737

Merged
merged 2 commits into from
May 7, 2024
Merged

Revert woo.com → woocommerce.com in URLs #2737

merged 2 commits into from
May 7, 2024

Conversation

layoutd
Copy link
Collaborator

@layoutd layoutd commented May 7, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Revert the woo.com → woocommerce.com in several places, especially for documentation links (pb0Spc-5mO-p2).

Also changes the homepage in package.json. Still unclear whether the author should be "Woo" instead of "Facebook".

Detailed test instructions:

  1. No real code changes (only in get_sales_page_url() and get_documentation_url()).
  2. Double check all new URLs actually go to a page.

Changelog entry

Tweak - Revert to WooCommerce.com domain.

@layoutd layoutd added the changelog: doc Updated customer- or developer-facing documentation label May 7, 2024
@layoutd layoutd self-assigned this May 7, 2024
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label May 7, 2024
@layoutd layoutd requested a review from a team May 7, 2024 09:58
rawdreeg
rawdreeg approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@rawdreeg rawdreeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that we replaced all occurrences of woo.com. And that all links are corrects.

I left a small nitpick for consideration.

README.md Outdated Show resolved Hide resolved
@layoutd layoutd removed the changelog: tweak Small change, that isn't actually very important. label May 7, 2024
@layoutd layoutd added changelog: tweak Small change, that isn't actually very important. and removed changelog: doc Updated customer- or developer-facing documentation labels May 7, 2024
@layoutd layoutd merged commit 1706c1c into develop May 7, 2024
4 checks passed
@layoutd layoutd deleted the tweak/revert-to-woocommerce-com branch May 7, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawdreeg rawdreeg rawdreeg approved these changes

Assignees

@layoutd layoutd

Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@layoutd @rawdreeg