Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined SETTING_ENABLE_DEBUG_MODE #2779

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix undefined SETTING_ENABLE_DEBUG_MODE #2779

merged 1 commit into from
Aug 8, 2024

Conversation

rawdreeg
Copy link
Contributor

@rawdreeg rawdreeg commented Aug 7, 2024

Changes proposed in this Pull Request:

This is something that escaped our attention in this PR: #2754. The constant SETTING_ENABLE_DEBUG_MODE should not be called from self. but from WC_Facebookcommerce_Integration.

Closes #2778.

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Screenshots:

Detailed test instructions:

Upgrade the plugin from version 1, and no errors should occur.

Changelog entry

Fix - Update failing due to undefined constant error in Lifecycle

@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Aug 7, 2024
@rawdreeg rawdreeg self-assigned this Aug 7, 2024
@rawdreeg rawdreeg requested a review from a team August 7, 2024 15:53
@rawdreeg rawdreeg changed the title fix constant SETTING_ENABLE_DEBUG_MODE should fix constant undefined SETTING_ENABLE_DEBUG_MODE Aug 7, 2024
@rawdreeg rawdreeg changed the title fix constant undefined SETTING_ENABLE_DEBUG_MODE fix undefined SETTING_ENABLE_DEBUG_MODE Aug 7, 2024
@lynnjat7
Copy link

lynnjat7 commented Aug 8, 2024

Just noting that the original reporting customer on this tried the code fix already (@rawdreeg provided it to me on Slack) and it worked, so looks like clear sailing for this fix.
8503847-zen

@rawdreeg
Copy link
Contributor Author

rawdreeg commented Aug 8, 2024

I'll merge this one without a review

@rawdreeg rawdreeg merged commit 8a1f523 into develop Aug 8, 2024
5 checks passed
@rawdreeg rawdreeg deleted the fix/2778 branch August 8, 2024 16:33
@ecgan
Copy link
Member

ecgan commented Aug 13, 2024

Closes #2278.

@rawdreeg , I believe you have a typo above. I have edited your PR description to "Closes #2778."

@rawdreeg
Copy link
Contributor Author

Thanks, @ecgan

@layoutd
Copy link
Collaborator

layoutd commented Aug 15, 2024

Thanks for identifying and cleaning this up, @rawdreeg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error: Uncaught Error: Undefined constant WooCommerce\Facebook\Lifecycle::SETTING_ENABLE_DEBUG_MODE
4 participants