Ability to control the product selection of synced products #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the ability to control the product selection of synced products.
Add apply_filters hook to prepare_query_args
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2006 +/- ##
=========================================
Coverage 57.9% 57.9%
Complexity 4111 4111
=========================================
Files 456 456
Lines 17658 17659 +1
=========================================
+ Hits 10224 10225 +1
Misses 7434 7434
Flags with carried forward coverage won't be shown. Click here to find out more.
|
puntope
reviewed
Jul 5, 2023
puntope
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Hi @andyg2
Thanks for opening this PR. Only two minor things for getting approval:
- Changing the name of the hook following the name convention of the other hooks (see my comment)
- Fix the PHPCS errors
|
FYI - This will be released potentially next Tuesday 25th July. |
eason9487
added
the
changelog: add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the ability to control the product selection of synced products.
Changes proposed in this Pull Request:
Adding an apply filters hook allows users more control over which products can be selected for syncing.
Closes #2005
Additional details:
Tweak - Ability to filter products for syncing via
gla_filter_product_query_argsapply_filters hook.Changelog entry
Tweak - Ability to filter products for syncing via
gla_filter_product_query_argsapply_filters hook.