-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client name and version as request headers #2008
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2008 +/- ##
===========================================
+ Coverage 57.9% 58.0% +0.1%
- Complexity 4111 4113 +2
===========================================
Files 456 456
Lines 17658 17669 +11
===========================================
+ Hits 10224 10255 +31
+ Misses 7434 7414 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/Unit/API/ClientTest.php
Outdated
use PluginHelper; | ||
|
||
/** | ||
* Confirm that the client handler stack includes the `plugin_version_header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closing backtick is missing.
Changes proposed in this Pull Request:
This PR adds two additional headers to requests sent to the WooCommerce Connect Server:
x-client-name
x-client-version
Detailed test instructions:
add/plugin-version-header
on a new test siteMarketing > Google Listings & Ads
and visit various sectionsChangelog entry