Apply AdaptiveForm
and its abilities to steps 2 and 3 of the onboarding flow for higher code consistent
#2015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
With #2014, this is another pre-processing PR for #634 and for 📌 Display form validation errors in #1993.
To apply
AdaptiveForm
and its abilities to steps 2 and 3 of the onboarding flow, and make the uses offormContext
( the formerformProps
) higher consistent, this PR:adapter.isSubmitting
ofAdaptiveForm
as the loading state of submit button inSetupFreeListings
andStoreRequirements
useAdaptiveFormContext
instead offormProps
prop drilling forSetupFreeListings
and the relevant components.AdaptiveForm
anduseAdaptiveFormContext
instead ofForm
andformProps
forStoreRequirements
and the relevant componentsaudienceCountries
prop drilling forSetupFreeListings
and the relevant components.💡 It's possible to continue the subsequent implementation without this PR, but the uses of form and the relevant states will become scattered and more difficult to maintain. Therefore, I would like to tweak the codebase first.
Detailed test instructions:
This PR only changes the code used in steps 2 and 3 of the onboarding flow but doesn't change the UI behaviors.
The
SetupFreeListings
component is used in the Edit free listings page as well.Changelog entry