PHP 8.2 Deprecation Messages #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2022 +/- ##
=========================================
Coverage 58.1% 58.1%
Complexity 4119 4119
=========================================
Files 455 455
Lines 17694 17695 +1
=========================================
+ Hits 10277 10278 +1
Misses 7417 7417
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martynmjones
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Hey @mikkamp,
Thanks for the quick fix 🙌
Tested locally to confirm that the PHP deprecation messages have been resolved and that everything is working as expected so LGTM ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR handles some PHP 8.2 deprecation messages. They were not caught in the original PR #1937 for PHP 8.2 because that code is not covered in unit testing. The code is mainly used for conditionally display on product and coupon pages which means it would fit better in E2E testing.
Closes #2021
Detailed test instructions:
Additional details:
With the latest version of WooCommerce and WordPress there are no longer any PHP 8.2 deprecation warnings. So this PR also enables PHP 8.2 unit testing in GitHub actions.
Changelog entry