Add JavaScript tests for the PhoneNumberCard component
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puntope
reviewed
Jul 28, 2023
Comment on lines
+100
to
+103
| mockLoaded( false ); | ||
| const { rerender } = render( | ||
| <PhoneNumberCard phoneNumber={ phoneNumber } /> | ||
| ); |
There was a problem hiding this comment.
I guess this can be omitted.
There was a problem hiding this comment.
This is to simulate the state change of "after loading a verified phone number".
puntope
reviewed
Jul 28, 2023
| expect( button ).not.toBeInTheDocument(); | ||
| } ); | ||
|
|
||
| it( 'When `initEditing` is not specified, should render in display mode after loading a verified phone number', () => { |
There was a problem hiding this comment.
"display mode" doesn't explain much. I guess it would be more accurate to say
should render the edit button after loading a verified phone number
There was a problem hiding this comment.
The mode for entering verification code also has an edit button. Changed to use "non-editing mode" in ca7ce02.
puntope
reviewed
Jul 28, 2023
Comment on lines
+114
to
+117
| mockLoaded( false ); | ||
| const { rerender } = render( | ||
| <PhoneNumberCard phoneNumber={ phoneNumber } /> | ||
| ); |
There was a problem hiding this comment.
I guess same as before, this seems not necessary
There was a problem hiding this comment.
This is to simulate the state change of "after loading an unverified phone number".
puntope
approved these changes
Jul 28, 2023
…oneNumberCard` tests. Address: #2027 (comment)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is a part of 📌 Add tests in #1993.
Before adding tests for the
VerifyPhoneNumberContentcomponent, I would like to add tests for thePhoneNumberCardcomponent first.Detailed test instructions:
Changelog entry