Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Our main goal is to convert E2E tests from Puppeteer to PlayWright, as well as remove any dependencies for the WooCommerce E2E packages (as they will be deprecated).
This PR is intended to setup a wp-env site for running the E2E tests against, which previously was done using a docker image as part of
@woocommerce/e2e-environment
package. A followup PR will address converting tests to PlayWright.Resolves part of #1599
Detailed test instructions:
nvm use && npm ci
wp-env
sitenpm run wp-env start
npm run test:e2e
and confirm it uses the sitehttp://localhost:8889
Additional details:
Some of the tests still fail, because the related products section has switched to blocks and also because some of the tests have been flaking. Since this is the reason we are switching to PlayWright, the failing tests will be addressed there.
It's still possible to get the previous test site up and running with
npm run docker:up
, all that will be removed once the full dependency on the WooCommerce packages is no longer needed. This is still being used by GitHub actions on release branches.The command to add a ready page was added because the
wc-e2e
script waits explicitly till this page is available. Once we convert to PlayWright it should be possible to remove this.Changelog entry