Externalize Dashicon
, Icon
, Notice
and Tip
components imported from @wordpress/components
#2037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
It's part of #1833
Dashicon
,Icon
,Notice
, andTip
components.@wordpress/primitives
package to use the DEWPed one.Icon
compatibility. Theicon.type === SVG
comparison result needs to betrue
.AppTooltip
CSS name in #1901.DismissibleNotice
that was missed to be removed in #1889.Screenshots:
📷
Dashicon
component on the Product Feed page📷
Icon
andNotice
components on the Get Started page📷
Tip
component on the Get Started page📷 The edit icon color was corrected to gray
📷 The CSS style of "N products" text wrapped by
AppTooltip
was correctedDetailed test instructions:
💡 It would be easier to test this PR by making a few changes locally:
return <IssuesSolved />;
to this line.Testing:
npm start
Icon
,Notice
andTip
components are shown correctly.Dashicon
components are shown correctly.'extracted/@wordpress/components'
.Changelog entry