Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize NavigableMenu, Dropdown and Modal components imported from @wordpress/components #2042

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

It's part of #1833

  • Externalize NavigableMenu, Dropdown and Modal components.
  • Remove an invalid CSS hack that had fixed the Tooltip position within a Modal before.
    • Currently, the minimum supported version of this extension is WP 5.9.
      • This hack doesn't work for WP 5.9 and 6.0.
      • WP >= 6.1 itself has already fixed this issue, so it's no longer needed.

Screenshots:

📷 NavigableMenu component on the Reports page

image

📷 Dropdown component on the Reports page

image

📷 Modal component on the Edit Free Listings page

image

📷 Tooltip position of the close button within a Modal for WP >= 6.1

1

Detailed test instructions:

  1. Go to the Reports page
  2. Check if the NavigableMenu component works well
    • AppTabNav: The main menu items
    • AppSubNav: The sub-menu items on the Reports page
  3. Check if the Dropdown component works well
    • The filter to select program(s)
  4. Go to the following pages to check if the Modal component works well
    • The welcome modal of completing onboarding: Open with a site URL with path: /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fproduct-feed&guide=submission-success
    • The modal to confirm account(s) disconnection
    • The shipping modals on the Edit Free Listings page
  5. Search the codebase to check if all these components are imported from 'extracted/@wordpress/components'.

Changelog entry

@eason9487 eason9487 requested a review from a team August 4, 2023 07:58
@eason9487 eason9487 self-assigned this Aug 4, 2023
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 4, 2023
… a Modal before.

Currently, the minimum supported version of this extension is WP 5.9.
- This hack doesn't work for WP 5.9 and 6.0.
- WP >= 6.1 itself has already fixed this issue, so it's no longer needed.
@eason9487 eason9487 force-pushed the dev/1833-externalize-menu-dropdown-modal branch from 99a4016 to de3a889 Compare August 4, 2023 09:57
Copy link
Contributor

@jorgemd24 jorgemd24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eason9487, for working on this! I tested it on WP 6.2 and the upcoming release 6.3, and it works perfectly. Looks good to me! 👍

Base automatically changed from dev/1833-externalize-icons-notice-tip to dev/externalize-wp-packages August 9, 2023 09:43
@eason9487 eason9487 merged commit 757ed21 into dev/externalize-wp-packages Aug 9, 2023
4 checks passed
@eason9487 eason9487 deleted the dev/1833-externalize-menu-dropdown-modal branch August 9, 2023 09:44
@eason9487 eason9487 mentioned this pull request Aug 22, 2023
17 tasks
@eason9487 eason9487 linked an issue Aug 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP < 6.1 Compatibility: Unable to open the programs filter
2 participants