Fetch WC L-1 versions

[puntope]

Changes proposed in this Pull Request:

This PR fetch WooCommerce L-1 versions for our tests using https://github.com/woocommerce/grow/tree/trunk/packages/github-actions/actions/get-plugin-releases

Detailed test instructions:

Verify the WC version is properly fetched and the test passing
https://github.com/woocommerce/google-listings-and-ads/actions/runs/5787000158/job/15682944873?pr=2046

Additional details:

Changelog entry

Dev - Fetch WooCommerce L-1 versions for our tests

[codecov]

Codecov Report

Merging #2046 (2da9e70) into develop (ff83ba8) will increase coverage by 0.2%.
Report is 34 commits behind head on develop.
The diff coverage is 63.3%.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop   #2046     +/-   ##
===========================================
+ Coverage       58.0%   58.2%   +0.2%     
+ Complexity      4121    4119      -2     
===========================================
  Files            455     454      -1     
  Lines          17715   17701     -14     
===========================================
+ Hits           10278   10297     +19     
+ Misses          7437    7404     -33     

Flag	Coverage Δ
php-unit-tests	58.2% <63.3%> (+0.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
google-listings-and-ads.php	6.4% <0.0%> (ø)
...ernal/DependencyManagement/CoreServiceProvider.php	0.0% <0.0%> (ø)
src/TaskList/CompleteSetupTask.php	67.9% <67.9%> (ø)

[tomalec]

Why do we switch to WC L-1?

IMHO, the opposite setup could be desired WC L-2, but WP L-1 - as that is what WC supports.

[puntope]

Why do we switch to WC L-1?

IMHO, the opposite setup could be desired WC L-2, but WP L-1 - as that is what WC supports.

We didn't do any switch. Actually, we increased from L-0 to L-1, if you check the old version it was fetching the latest WC version.

In regards to the policies, I checked https://woogrowp2.wordpress.com/2023/07/31/l-1-policy/ but I didn't see any accepted answer yet with the final consensus, so I lean to keep it as it was until we decide.

[mikkamp]

Thanks for the changes, this is working as expected. I left a few comments but none of them are blocking.

I do agree with Tomek that we might as well bump this to WC L-2 even if we aren't testing every single combination.

[mikkamp]

Same as comment https://github.com/woocommerce/automatewoo/pull/1527/files#r1286879075
Does it make sense to merge this as one job?

[puntope]

Done ✅

[mikkamp]

In the interest of not testing all combinations (to save billing minutes), on other extensions we make this test do the oldest supported version of everything. So in that case wouldn't this need to be PHP 7.4, WP L-2, WC L-1.
Since this is the only test that uses an older version of WC I wouldn't be against changing this to WC L-2.

[puntope]

I changed the matrix, now we follow the same as Automatewoo

[mikkamp]

We might as well add an additional check to make sure WC is at latest version to ensure the coverage report is only generated on one run. Right now it will still run only once but if we tweak the matrix later on then it would be easy to miss:

Suggested change

	- if: matrix.wp-version == needs.GetWPMatrix.outputs.latest-wp-version && matrix.php == 8.0
	- if: matrix.wp-version == needs.GetWPMatrix.outputs.latest-wp-version && matrix.wc-version == needs.GetWCMatrix.outputs.latest-wc-version && matrix.php == 8.0

[puntope]

This is done as well, as we are now changing the matrix I check PHP 8.0 and WC latest

[mikkamp]

The suggestion to check all three was in case we would test more combinations of WP as well. But not a big deal since as you mentioned it is cover how it is now.

[puntope]

Hi @tomalec and @mikkamp I did some changes and change to WC - WP L-2

This is ready for another round

[mikkamp]

Thanks for the changes, they are working well.

The only minor comment I have left is that none of the combinations test WP L-1. Maybe for variety we could pass that to the PHP 8.1 test.