-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-in all @wordpress
packages imports via DEWP
#2055
Opt-in all @wordpress
packages imports via DEWP
#2055
Conversation
…m the external source of DEWP.
Awsome, that's pretty heavy reduction in the bundle size :)
According to Details
With WP L-1, we're safe for sure, it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the code & bundles and smoke-tested crucial flows. LGTM.
…ation process" This reverts commit 2d0e0d6.
Changes proposed in this Pull Request:
It's the final part of #1833
To opt-in all
@wordpress
packages imports via DEWP and revert all gradually externalized@wordpress/components
imports, this PR:extracted/
prefix from all'extracted/@wordpress/components'
imports.@wordpress/components
and@wordpress/compose
to import from the external source of DEWP.requestToExternal
array in the webpack config. So that all their imports will be externalized via regular DEWP instead of the mechanism ofextracted/
prefix.@wordpress/compose
package was removed together as the following uses don't have external changes after@wordpress/compose
5.1.2 (used by WC 6.9):createHigherOrderComponent
useFocusOutside
: refactor to TypeScriptuseInstanceId
: refactor to TypeScriptuseReducedMotion
useViewportMatch
DatePicker
as it has been fixed since WC 7.2.DatePicker
component #1739Screenshots:
Detailed test instructions:
npm start
,npm run dev
,npm run start:hot
andnpm run build
, can run successfully.npm run env -- NODE_ENV=production wp-scripts build --webpack-bundle-analyzer
@wordpress/*
package included in the build bundle.@wordpress/icons
is not a DEWPed package. Ref'extracted/@wordpress/components'
import.Changelog entry