Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HookDocsGenerator legacy file #2065

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 21, 2023

Changes proposed in this Pull Request:

This PR is a follow up for #2060

After adding a workflow for generating the Hook Documentation. We can remove the legacy file bin/HooksDocsGenerator.php

Detailed test instructions:

  1. No references to bin/HooksDocsGenerator.php can be found in the codebase.

Additional details:

Changelog entry

Dev - Remove legacy HooksDocsGenerator.php file.

@puntope puntope requested a review from a team August 21, 2023 07:02
@puntope puntope self-assigned this Aug 21, 2023
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #2065 (efec923) into develop (96a5d61) will not change coverage.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

❗ Current head efec923 differs from pull request most recent head da25796. Consider uploading reports for the commit da25796 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #2065   +/-   ##
=========================================
  Coverage       58.3%   58.3%           
  Complexity      4114    4114           
=========================================
  Files            454     454           
  Lines          17676   17676           
=========================================
  Hits           10297   10297           
  Misses          7379    7379           
Flag Coverage Δ
php-unit-tests 58.3% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@puntope puntope marked this pull request as ready for review August 21, 2023 07:18
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This script can be removed together:

"doc:hooks": "php bin/HooksDocsGenerator.php",

@puntope puntope merged commit 51368d3 into develop Aug 21, 2023
12 checks passed
@puntope puntope deleted the dev/remove-hook-generator-file branch August 21, 2023 12:13
@eason9487 eason9487 mentioned this pull request Aug 22, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants