Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests: Dashboard - Edit Free Listings #2080
E2E tests: Dashboard - Edit Free Listings #2080
Changes from 1 commit
68d76b3
edbd0cd
251de35
acd00aa
280b8f8
f76fb1d
551b385
d722ba4
0a84f51
9c5010d
82fdb76
d3b3448
0664818
d520d8b
c5942d6
a19a8a8
d68f4d7
4b4f063
62f6270
097f2fb
e68a11e
819250b
5a9c0e2
3e7fbdb
d0c9172
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: should be "Audience".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔We didn't mock this request
/gla/mc/settings/sync
and by runningnpm run test:e2e-dev tests/e2e/specs/dashboard/edit-free-listings.test.js
I saw this request returned500
server error with the messagePlease reconnect your Jetpack account.
. Although the test still passed since we only check the response fromgla/mc/settings
API, do you think it'd be a good idea to mock/gla/mc/settings/sync
API so it wouldn't respond the error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first, I didn't mock the response because I believed there wasn't much to test. But now I realize we can actually verify the message in the snackbar. See here: 5a9c0e2