E2E tests: Onboarding Step 3 - Confirm store requirements #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemd24
reviewed
Sep 13, 2023
tests/e2e/specs/setup-mc/step-3-confirm-store-requirements.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/utils/pages/setup-mc/step-3-confirm-store-requirements.js
Outdated
Show resolved
Hide resolved
…onfigure-product-listings' into dev/2070-e2e-onboarding-step-3-confirm-store-requirements
in onboarding step 3 e2e test
|
Hey @jorgemd24, thanks for reviewing and the nice suggestions. I've updated the code based on your suggestions and it's ready for another round of review. |
Base automatically changed from
dev/2070-e2e-onboarding-step-2-configure-product-listings
to
develop
September 18, 2023 02:18
ianlin
deleted the
dev/2070-e2e-onboarding-step-3-confirm-store-requirements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes part of #2070, this PR adds E2E tests for 📌 Onboarding Step 3 - Confirm store requirements.
Detailed test instructions:
npm run test:e2e -- ./tests/e2e/specs/setup-mc/step-3-confirm-store-requirements.test.js, the test should pass.npm run test:e2e-dev -- ./tests/e2e/specs/setup-mc/step-3-confirm-store-requirements.test.js, check the test in the chromium step by step.npm run test:e2eto make sure all tests are passed.Changelog entry