-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E - Ads Paid Campaign Step 1 - Connect Ads Account #2097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests of connecting ads account. They covered most of the scenarios and tests had passed on my local. I left some comments about separating tests so it would be a bit more explanatory.
…gs' into dev/2070-e2e-add-ads-account
Thanks @ianlin for your suggestions, I addressed all of them! This is ready for another round, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra changes, LGTM. 👍
Changes proposed in this Pull Request:
Closes part of #2070.
This PR includes E2E tests for the initial stage of setting up an Ads Campaign, which involves connecting the accounts.
Detailed test instructions:
npm run test:e2e -- ./tests/e2e/specs/add-paid-campaigns/step-1-accounts.test.js
, the test should pass.npm run test:e2e-dev -- ./tests/e2e/specs/add-paid-campaigns/step-1-accounts.test.js
, check the test in the chromium step by step.Changelog entry