Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E - Ads Paid Campaign Step 1 - Connect Ads Account #2097

Merged
merged 12 commits into from
Sep 18, 2023

Conversation

jorgemd24
Copy link
Contributor

@jorgemd24 jorgemd24 commented Sep 14, 2023

Changes proposed in this Pull Request:

Closes part of #2070.

This PR includes E2E tests for the initial stage of setting up an Ads Campaign, which involves connecting the accounts.

Detailed test instructions:

  1. Follow these steps to set up the e2e env: https://github.com/woocommerce/google-listings-and-ads#e2e-testing
  2. Run npm run test:e2e -- ./tests/e2e/specs/add-paid-campaigns/step-1-accounts.test.js, the test should pass.
  3. Or, run npm run test:e2e-dev -- ./tests/e2e/specs/add-paid-campaigns/step-1-accounts.test.js, check the test in the chromium step by step.
  4. Run npm run test:e2e to make sure all tests are passed. (The tests associated with the gtag event are currently failing, but there has already been a fix implemented in this PR E2E Tests failing with WooCommerce 8.1.0 #2095)

Changelog entry

Dev - E2E - Ads a paid campaign Step 1 - Connect Ads Account

@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Sep 14, 2023
@jorgemd24 jorgemd24 self-assigned this Sep 14, 2023
@jorgemd24 jorgemd24 changed the title Dev/2070 e2e add ads account E2E - Ads a paid campaign Step 1 - Connect Ads Account Sep 14, 2023
@jorgemd24 jorgemd24 marked this pull request as ready for review September 14, 2023 16:13
@jorgemd24 jorgemd24 changed the title E2E - Ads a paid campaign Step 1 - Connect Ads Account E2E - Ads Paid Campaign Step 1 - Connect Ads Account Sep 14, 2023
@jorgemd24 jorgemd24 requested a review from a team September 14, 2023 17:33
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests of connecting ads account. They covered most of the scenarios and tests had passed on my local. I left some comments about separating tests so it would be a bit more explanatory.

tests/e2e/utils/pages/setup-ads/setup-ads-accounts.js Outdated Show resolved Hide resolved
tests/e2e/utils/pages/setup-ads/setup-ads-accounts.js Outdated Show resolved Hide resolved
tests/e2e/utils/pages/setup-ads/setup-ads-accounts.js Outdated Show resolved Hide resolved
tests/e2e/utils/pages/setup-ads/setup-ads-accounts.js Outdated Show resolved Hide resolved
@jorgemd24
Copy link
Contributor Author

Thanks @ianlin for your suggestions, I addressed all of them! This is ready for another round, thanks!

Base automatically changed from dev/2070-e2e-onboarding-step-2-configure-product-listings to develop September 18, 2023 02:18
Copy link
Member

@ianlin ianlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra changes, LGTM. 👍

@jorgemd24 jorgemd24 merged commit f7c2fcb into develop Sep 18, 2023
4 checks passed
@jorgemd24 jorgemd24 deleted the dev/2070-e2e-add-ads-account branch September 18, 2023 15:08
@jorgemd24 jorgemd24 mentioned this pull request Sep 20, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants