Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (budget and audiences) tracking for Onboarding completed with Ads #2167

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Nov 30, 2023

Changes proposed in this Pull Request:

This is a continuation for #2153

This PR adds the Tracking events with the budget and the audience when the onboarding is completed adding Ads.

  • It only adds Budget and Audiences

Screenshots:

Screenshot 2023-11-30 at 20 07 40

Detailed test instructions:

  1. Enable tracks debugger --> Add this to yourBrowser console --> localStorage.setItem( 'debug', 'wc-admin:*' )
  2. Start a fresh Onboarding
  3. In the final step connect Ads and create a campaign
  4. Set a budget
  5. Complete the setup
  6. See the track event with the budget and the audiences.

Additional details:

Changelog entry

Tweak - Track Budgets and Audience in Onboarding

@github-actions github-actions bot added changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement. labels Nov 30, 2023
@puntope puntope self-assigned this Nov 30, 2023
@puntope puntope added changelog: dev Developer-facing only change. and removed changelog: add A new feature, function, or functionality was added. labels Nov 30, 2023
@puntope puntope requested a review from a team November 30, 2023 23:23
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work.

There are questions about the call timing of event tracking and whether to merge event tracking. I think they need to be clarified first.

@eason9487
Copy link
Member

Just noticed another thing. Event tracking also involves extension users. Should it belong to the changelog: dev category?

@puntope puntope added changelog: tweak Small change, that isn't actually very important. and removed changelog: dev Developer-facing only change. labels Dec 11, 2023
@puntope
Copy link
Contributor Author

puntope commented Dec 11, 2023

Howdy @eason9487 Thanks for reviewing this.

I applied your suggestion as it fixes the race problem and reuses the gla_onboarding_complete_with_paid_ads_button_click existing event so now it should be consistent.

I updated also from changelog:dev to changelog:tweak

Can you help with a new round of reviews?

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustment.

It still needs a bit of tweak as the initial paidAds.countryCodes is undefined.

@puntope
Copy link
Contributor Author

puntope commented Dec 12, 2023

Hi @eason9487 thanks again for the review and for the catch.

Sorry. I saw that error yesterday and forgot to push it 😵‍💫

Can you do a new round? Thanks.

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@puntope puntope merged commit 185f3f8 into develop Dec 13, 2023
5 checks passed
@puntope puntope deleted the add/tracking-budget-onboarding-setup-ads branch December 13, 2023 10:23
@puntope puntope mentioned this pull request Dec 18, 2023
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants