Support for cart-add-item hook in WC 8.5
#2192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: fix
eason9487
reviewed
Jan 3, 2024
There was a problem hiding this comment.
Thanks for the work. I can reproduce the issue with Woo 8.5.0-beta.1 and the Products (Beta) block.
I believe it was caused by woocommerce/woocommerce#42946 and has been reverted by woocommerce/woocommerce#43177. After testing with Woo 8.5.0-rc.1, the issue no longer occurs. Therefore, this PR should not need to be merged.
Ref: pf59Ax-wM-p2
|
Correct @eason9487 It was confirmed as well by woo-blocks team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2191.
This PR closes a bug in GLA when using WC8.5 and Product Blocks. In WC 8.5 we receive a Proxy Product as a parameter. Before we got 2, product and quantity
Detailed test instructions:
Additional details:
Changelog entry