Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2: Updated Enhanced Conversion flow #2361

Open
wants to merge 14 commits into
base: feature/2239-enhanced-conversions-panel
Choose a base branch
from
Open

R2: Updated Enhanced Conversion flow #2361

wants to merge 14 commits into from

Commits on Apr 9, 2024

  1. Add minor CR feedback.

    @asvinb
    asvinb committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5e72c9e View commit details
    Browse the repository at this point in the history

  2. Review enhanced conversions panel wordings and CTAs.

    @asvinb
    asvinb committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5033e0d View commit details
    Browse the repository at this point in the history

  3. Refactor EC pannel settings.

    @asvinb
    asvinb committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2582e18 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Changes to useTermsPolling hook.

    @asvinb
    asvinb committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    0a35f0c View commit details
    Browse the repository at this point in the history

  2. Delete unused useGoogleAdsEnhancedConversionTermsURL.js.

    @asvinb
    asvinb committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    891676a View commit details
    Browse the repository at this point in the history

  3. Simplify useGoogleAdsEnhancedConversionSettingsURL.js hook.

    @asvinb
    asvinb committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ec33c2a View commit details
    Browse the repository at this point in the history

  4. Removed unused imports.

    @asvinb
    asvinb committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    6a95b1f View commit details
    Browse the repository at this point in the history

  5. Remove copy to minimize modal height.

    @asvinb
    asvinb committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    95cc03e View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Address CR feedback.

    @asvinb
    asvinb committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    489a3f4 View commit details
    Browse the repository at this point in the history

  2. Address CR feedback.

    @asvinb
    asvinb committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9141797 View commit details
    Browse the repository at this point in the history

  3. Remove unused import.

    @asvinb
    asvinb committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5f4648f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Add Success screen.

    @asvinb
    asvinb committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e9dcd38 View commit details
    Browse the repository at this point in the history

  2. Fix failing tests.

    @asvinb
    asvinb committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1671f7c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Address CR feedback.

    @asvinb
    asvinb committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    62b19a2 View commit details
    Browse the repository at this point in the history