-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable users to seamlessly set up conversion tracking during the onboarding flow #2415
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2415 +/- ##
============================================
- Coverage 64.2% 63.4% -0.7%
============================================
Files 755 321 -434
Lines 21538 5027 -16511
Branches 1157 1218 +61
============================================
- Hits 13818 3188 -10630
+ Misses 7559 1672 -5887
- Partials 161 167 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…don't have to validate global event properties.
…s across multiple layers of components via `@wordpress/hooks`.
…ding steppers for use by their subcomponents.
… in `TermsModal`.
…oid different hook entities affecting each other. Address: #2419 (comment)
… in `ConnectAds`.
… in `DisconnectAccount`.
…racking in `BillingSetupCard`.
…st a callback argument to make its purpose clearer. Address: #2419 (comment)
…art-1 Adjust event tracking for the creating and claim buttons of Google Ads account
…art-2 Adjust click event tracking when connecting, disconnecting, and opening billing setup for Google Ads account
PHP Unit Tests failed because WooCommerce did backport fixes for versions 7.8.3-8.9.2, but these versions are listed in WordPress.org API but are still draft releases on GitHub. It should be fine to continue the merge as the test passed in c5fe2d8 and the subsequent commits don't have any PHP changes. |
Changes proposed in this Pull Request:
Closes #2215
This PR wraps up all PRs related to #2215:
📌 Checklist before merging
develop
branch and update tracking README fileChangelog entry