Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to seamlessly set up conversion tracking during the onboarding flow #2415

Merged
merged 224 commits into from
Jun 5, 2024

Conversation

ankitrox and others added 30 commits January 12, 2024 18:45
Make merchant account non-required for ads account setup
…-step1-followup

Move useGoogleAccountCheck to its own file.
Update tests for conversion tracking without a merchant account
@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label May 29, 2024
@eason9487 eason9487 self-assigned this May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 76.24309% with 43 lines in your changes missing coverage. Please review.

Project coverage is 63.4%. Comparing base (6eb93ab) to head (340cb89).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2415      +/-   ##
============================================
- Coverage       64.2%   63.4%    -0.7%     
============================================
  Files            755     321     -434     
  Lines          21538    5027   -16511     
  Branches        1157    1218      +61     
============================================
- Hits           13818    3188   -10630     
+ Misses          7559    1672    -5887     
- Partials         161     167       +6     
Flag Coverage Δ
js-unit-tests 63.4% <76.2%> (+0.6%) ⬆️
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
js/src/components/account-card/index.js 96.8% <ø> (ø)
...ts/google-ads-account-card/claim-account-button.js 100.0% <100.0%> (ø)
...nts/google-ads-account-card/claim-account/index.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/connect-ads/index.js 96.0% <100.0%> (ø)
...-account-card/connected-google-ads-account-card.js 0.0% <ø> (ø)
...s/google-ads-account-card/create-account-button.js 11.1% <100.0%> (ø)
...omponents/google-ads-account-card/disabled-card.js 100.0% <100.0%> (ø)
...ents/google-ads-account-card/disconnect-account.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/terms-modal/index.js 100.0% <100.0%> (ø)
...onents/paid-ads/billing-card/billing-setup-card.js 92.9% <100.0%> (+63.4%) ⬆️
... and 18 more

... and 469 files with indirect coverage changes

…don't have to validate global event properties.
…s across multiple layers of components via `@wordpress/hooks`.
…ding steppers for use by their subcomponents.
…oid different hook entities affecting each other.

Address: #2419 (comment)
…st a callback argument to make its purpose clearer.

Address: #2419 (comment)
…art-1

Adjust event tracking for the creating and claim buttons of Google Ads account
…art-2

Adjust click event tracking when connecting, disconnecting, and opening billing setup for Google Ads account
@eason9487 eason9487 marked this pull request as ready for review June 5, 2024 09:28
@eason9487
Copy link
Member Author

PHP Unit Tests failed because WooCommerce did backport fixes for versions 7.8.3-8.9.2, but these versions are listed in WordPress.org API but are still draft releases on GitHub.

image

336712283-0e155919-aa6b-482e-89c4-a770e39f6bad

It should be fine to continue the merge as the test passed in c5fe2d8 and the subsequent commits don't have any PHP changes.

@eason9487 eason9487 merged commit 7625045 into develop Jun 5, 2024
10 of 15 checks passed
@eason9487 eason9487 deleted the feature/seamlessly-conversion-tracking branch June 5, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
6 participants