Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change connection test page capabilities to manage_woocommerce #2443

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Change connection test page capabilities to manage_woocommerce #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbcff08
Change connection test page capabilities to manage_woocommerce
jorgemd24 Jun 25, 2024
0f7944a
Fix phpcs
jorgemd24 Jun 25, 2024
e048937
Fix phpcs account service test
jorgemd24 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ConnectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@
add_menu_page(
'Connection Test',
'Connection Test',
'manage_options',
'manage_woocommerce',

Check warning on line 101 in src/ConnectionTest.php

View check run for this annotation

Codecov / codecov/patch

src/ConnectionTest.php#L101 

Added line #L101 was not covered by tests
'connection-test-admin-page',
function() {
function () {

Check warning on line 103 in src/ConnectionTest.php

View check run for this annotation

Codecov / codecov/patch

src/ConnectionTest.php#L103 

Added line #L103 was not covered by tests
$this->render_admin_page();
}
);
Expand All @@ -109,9 +109,9 @@
'',
'Connection Test',
'Connection Test',
'manage_options',
'manage_woocommerce',

Check warning on line 112 in src/ConnectionTest.php

View check run for this annotation

Codecov / codecov/patch

src/ConnectionTest.php#L112 

Added line #L112 was not covered by tests
'connection-test-admin-page',
function() {
function () {

Check warning on line 114 in src/ConnectionTest.php

View check run for this annotation

Codecov / codecov/patch

src/ConnectionTest.php#L114 

Added line #L114 was not covered by tests
$this->render_admin_page();
}
);
Expand Down
28 changes: 14 additions & 14 deletions tests/Unit/MerchantCenter/AccountServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,20 +118,20 @@ class AccountServiceTest extends UnitTest {
public function setUp(): void {
parent::setUp();

$this->ads = $this->createMock( Ads::class );
$this->cleanup_synced = $this->createMock( CleanupSyncedProducts::class );
$this->merchant = $this->createMock( Merchant::class );
$this->mc_service = $this->createMock( MerchantCenterService::class );
$this->issue_table = $this->createMock( MerchantIssueTable::class );
$this->merchant_statuses = $this->createMock( MerchantStatuses::class );
$this->middleware = $this->createMock( Middleware::class );
$this->site_verification = $this->createMock( SiteVerification::class );
$this->rate_table = $this->createMock( ShippingRateTable::class );
$this->time_table = $this->createMock( ShippingTimeTable::class );
$this->state = $this->createMock( MerchantAccountState::class );
$this->ads_state = $this->createMock( AdsAccountState::class );
$this->options = $this->createMock( OptionsInterface::class );
$this->transients = $this->createMock( TransientsInterface::class );
$this->ads = $this->createMock( Ads::class );
$this->cleanup_synced = $this->createMock( CleanupSyncedProducts::class );
$this->merchant = $this->createMock( Merchant::class );
$this->mc_service = $this->createMock( MerchantCenterService::class );
$this->issue_table = $this->createMock( MerchantIssueTable::class );
$this->merchant_statuses = $this->createMock( MerchantStatuses::class );
$this->middleware = $this->createMock( Middleware::class );
$this->site_verification = $this->createMock( SiteVerification::class );
$this->rate_table = $this->createMock( ShippingRateTable::class );
$this->time_table = $this->createMock( ShippingTimeTable::class );
$this->state = $this->createMock( MerchantAccountState::class );
$this->ads_state = $this->createMock( AdsAccountState::class );
$this->options = $this->createMock( OptionsInterface::class );
$this->transients = $this->createMock( TransientsInterface::class );
$this->notifications_service = $this->createMock( NotificationsService::class );

$this->container = new Container();
Expand Down