-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Pull] Enable notifications by default #2448
[API Pull] Enable notifications by default #2448
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/google-api-project #2448 +/- ##
==============================================================
- Coverage 64.7% 64.4% -0.3%
- Complexity 4550 4551 +1
==============================================================
Files 473 795 +322
Lines 17747 22796 +5049
Branches 0 1219 +1219
==============================================================
+ Hits 11483 14688 +3205
- Misses 6264 7941 +1677
- Partials 0 167 +167
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @puntope for working on this. It works well, but I noticed that if you add the filter add_filter('woocommerce_gla_notifications_enabled', '__return_false');
, the merchant won't be able to revoke access even if the status is approved
. Shouldn't we allow the merchant to revoke access in the settings page regardless of the filter value? (Connection Test page is OK)
Hi @jorgemd24 I tweaked the code based on your comments. I also added some info in the Connection Test. Can we have a new look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the adjustments. LGTM 👍
Changes proposed in this Pull Request:
This is a follow-up from this conversation p1719565119808809-slack-C02BB3F30TG
The PR enables Notifications feature by default
Detailed test instructions:
add_filter( 'woocommerce_gla_notifications_enabled', '__return_false' );
Additional details:
Changelog entry