Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API PULL] Add E2E tests for Notifications Grant Access #2474

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jul 21, 2024

Changes proposed in this Pull Request:

This PR adds an e2e test for banner that grants access to the WPCOM API.

Screenshots:

Screenshot 2024-07-21 at 17 35 34

Detailed test instructions:

  1. Run. npm run test:e2e notifications.test.js test pass
  2. See E2E test In GH Action passing

Additional details:

Changelog entry

@puntope puntope self-assigned this Jul 21, 2024
@puntope puntope marked this pull request as ready for review July 21, 2024 13:41
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jul 21, 2024
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.5%. Comparing base (0159630) to head (4380d21).
Report is 17 commits behind head on feature/google-api-project.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             feature/google-api-project   #2474      +/-   ##
===============================================================
- Coverage                          64.8%   63.5%    -1.3%     
===============================================================
  Files                               473     322     -151     
  Lines                             17801    5043   -12758     
  Branches                              0    1220    +1220     
===============================================================
- Hits                              11535    3204    -8331     
+ Misses                             6266    1672    -4594     
- Partials                              0     167     +167     
Flag Coverage Δ
js-unit-tests 63.5% <ø> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 795 files with indirect coverage changes

@puntope puntope requested a review from a team July 21, 2024 13:50
Copy link
Contributor

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @puntope,

Thanks for expanding our test suite. The changes look good to me ✅

@puntope puntope merged commit 45952f6 into feature/google-api-project Jul 23, 2024
8 checks passed
@puntope puntope deleted the dev/notifications-e2e-grant-acess branch July 23, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants