Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding Google Listings and Ads #2481

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Rebranding Google Listings and Ads #2481

merged 9 commits into from
Jul 26, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jul 26, 2024

@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 64.5%. Comparing base (d6500c1) to head (c02abe3).
Report is 328 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2481      +/-   ##
============================================
+ Coverage       63.4%   64.5%    +1.1%     
- Complexity         0    4564    +4564     
============================================
  Files            321     795     +474     
  Lines           5027   22844   +17817     
  Branches        1219    1220       +1     
============================================
+ Hits            3188   14739   +11551     
- Misses          1672    7938    +6266     
  Partials         167     167              
Flag Coverage Δ
js-unit-tests 63.5% <ø> (+0.1%) ⬆️
php-unit-tests 64.8% <33.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
google-listings-and-ads.php 75.0% <ø> (ø)
js/src/attribute-mapping/index.js 100.0% <ø> (ø)
js/src/components/tours/campaign-assets-tour.js 12.5% <ø> (ø)
js/src/dashboard/all-programs-table-card/index.js 100.0% <ø> (ø)
js/src/dashboard/index.js 78.1% <ø> (ø)
js/src/index.js 79.5% <ø> (ø)
js/src/product-feed/index.js 100.0% <ø> (ø)
...src/product-feed/submission-success-guide/index.js 65.2% <ø> (ø)
src/API/Google/AdsConversionAction.php 97.4% <100.0%> (ø)
src/Admin/Product/Attributes/AttributesTrait.php 100.0% <ø> (ø)
... and 28 more

... and 444 files with indirect coverage changes

@puntope puntope self-assigned this Jul 26, 2024
@puntope puntope marked this pull request as ready for review July 26, 2024 11:49
@puntope puntope merged commit c3f4679 into develop Jul 26, 2024
17 checks passed
@puntope puntope deleted the tweak/rebranding branch July 26, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant