[API PULL] Adding more tests for Notifications

[puntope]

Changes proposed in this Pull Request:

This PR adds more tests for Notification Schedules in API Pull

Screenshots:

Detailed test instructions:

1. See the test passing locally in your machine npm run test:e2e notifications
2. See the test passing in GH Actions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.5%. Comparing base (c3f4679) to head (a1a0ff7).

Additional details and impacted files

@@             Coverage Diff              @@
##             develop   #2482      +/-   ##
============================================
- Coverage       64.5%   63.5%    -1.0%     
============================================
  Files            795     322     -473     
  Lines          22844    5043   -17801     
  Branches        1220    1220              
============================================
- Hits           14739    3204   -11535     
+ Misses          7938    1672    -6266     
  Partials         167     167              

Flag	Coverage Δ
js-unit-tests	63.5% <ø> (ø)
php-unit-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 473 files with indirect coverage changes

[ianlin]

Thanks for adding e2e tests for notifications. All the tests have passed in my local, LGTM.

Just a note that it initially failed in my local with the following error:

✘  6 [chromium] › notifications/notifications-schedule.test.js:67:6 › Notifications Schedule › When Notifications are ready. Notifications are scheduled (35.2s)

      at ../utils/product-editor.js:263

  261 | 			return expect(
  262 | 				page.locator( '.product_data_tabs li.active' )
> 263 | 			).toHaveCount( 1 );
      | 			  ^
  264 | 		},
  265 |
  266 | 		async clickPluginTab() {

    at Object.waitForInteractionReady (/Users/ianlin/dev/automattic/google-listings-and-ads/tests/e2e/utils/product-editor.js:263:6)
    at Object.gotoAddProductPage (/Users/ianlin/dev/automattic/google-listings-and-ads/tests/e2e/utils/product-editor.js:170:15)
    at /Users/ianlin/dev/automattic/google-listings-and-ads/tests/e2e/specs/notifications/notifications-schedule.test.js:69:3

After checking a bit and found it's because my local wp-env docker was built previously, and it had the new product block editor feature enabled. In your tests it tested on the classic product editor so the error occurred. Maybe we could make it a follow up by disabling the new product block editor feature when testing on classic product editor. We currently turn on the product block feature when testing it, but not the other way around.

[puntope]

Thanks for adding e2e tests for notifications. All the tests have passed in my local, LGTM.

Just a note that it initially failed in my local with the following error:

✘  6 [chromium] › notifications/notifications-schedule.test.js:67:6 › Notifications Schedule › When Notifications are ready. Notifications are scheduled (35.2s)

      at ../utils/product-editor.js:263

  261 | 			return expect(
  262 | 				page.locator( '.product_data_tabs li.active' )
> 263 | 			).toHaveCount( 1 );
      | 			  ^
  264 | 		},
  265 |
  266 | 		async clickPluginTab() {

    at Object.waitForInteractionReady (/Users/ianlin/dev/automattic/google-listings-and-ads/tests/e2e/utils/product-editor.js:263:6)
    at Object.gotoAddProductPage (/Users/ianlin/dev/automattic/google-listings-and-ads/tests/e2e/utils/product-editor.js:170:15)
    at /Users/ianlin/dev/automattic/google-listings-and-ads/tests/e2e/specs/notifications/notifications-schedule.test.js:69:3

After checking a bit and found it's because my local wp-env docker was built previously, and it had the new product block editor feature enabled. In your tests it tested on the classic product editor so the error occurred. Maybe we could make it a follow up by disabling the new product block editor feature when testing on classic product editor. We currently turn on the product block feature when testing it, but not the other way around.

INteresting @ianlin Yes. I will create an issue for this.