-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Readme FAQ and remove video for wporg #2497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, this looks good to me. And still validates fine in the readme validator: https://wordpress.org/plugins/developers/readme-validator/
I just left one question about HTML markup. Is the banner image going to be changing on this page, or is that part of a separate PR?
If you’re selling in the US, then eligible free listings can appear in search results across Google Search, Google Images, and the Google Shopping tab. If you're selling outside the US, free listings will appear on the Shopping tab. | ||
= What is Product Sync? = | ||
Product Sync is a feature fully integrated into WooCommerce’s management platform that automatically lets you sync your product feed to Google Merchant Center. It will sync all your WooCommerce product data, and you can also add or edit products individually or in bulk. To ensure products are approved by Google, check that your product feed includes the following information: | ||
<p> <br> </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this line is going to be parsed correctly? The readme.txt file should be in markdown, I don't see any mention of how html tags are parsed. Would the formatting get mixed up if we just leave this line out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @mikkamp. The reason of this line is that the list miss the margin and looks very close to the paragraph. With that line, it seems to be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully that gets parsed correctly then.
|
Changes proposed in this Pull Request:
This PR upgrades readme.txt for changing WP.org plugin page
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry