Add Shipping Max time column in gla_shipping_times Table

[jorgemd24]

Changes proposed in this Pull Request:

Part of pcTzPl-2qP-p2

This PR updates the DB to support minimum and maximum shipping times. We'll keep the existing time column (which will be used as min time) for backwards compatibility and add a new column called max_time, which will be populated with the current values from the time column for existing users.

Once the UI is set up to handle max and min times, we’ll update the backend to manage these new columns accordingly.

Screenshots:

Detailed test instructions:

1. Edit your Free Listing to have different countries and shipping times.
2. Update the Migration class to your current GLA version: https://github.com/woocommerce/google-listings-and-ads/pull/2520/files#diff-898d6eb44e5ad0a4ef4f1b8ac7af29f6d561f5ddfb30b1ab79398dd81a629df8R46 for example: 2.8.1
3. Adjust the gla_db_version option to an older version, such as 2.8.0, so that the migration class is triggered.: UPDATE wp_options SET option_value = '2.8.0' WHERE option_name = 'gla_db_version';
4. Refresh the GFW page.
5. Check the DB and see that there is a new column called max_time and is populated with the values used in time.
6. To simulate a new installation run the following queries:

DROP TABLE wp_gla_shipping_times;
DELETE FROM wp_options WHERE `option_name` = 'gla_db_version';

7. Refresh and see that a new column is added.

Additional details:

I didn’t include tests since this code will only run once.

Changelog entry

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (update/shippings-settings-phase-1@9f669d4). Learn more about missing BASE report.

Files	Patch %	Lines
src/DB/Migration/Migration20240813T1653383133.php	0.0%	9 Missing ⚠️
...nternal/DependencyManagement/DBServiceProvider.php	0.0%	1 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                         @@
##             update/shippings-settings-phase-1   #2520   +/-   ##
===================================================================
  Coverage                                     ?   65.0%           
  Complexity                                   ?    4585           
===================================================================
  Files                                        ?     476           
  Lines                                        ?   17898           
  Branches                                     ?       0           
===================================================================
  Hits                                         ?   11626           
  Misses                                       ?    6272           
  Partials                                     ?       0           

Flag	Coverage Δ
php-unit-tests	65.0% <0.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/DB/Table/ShippingTimeTable.php	53.8% <ø> (ø)
...nternal/DependencyManagement/DBServiceProvider.php	0.0% <0.0%> (ø)
src/DB/Migration/Migration20240813T1653383133.php	0.0% <0.0%> (ø)

[jorgemd24]

Since the table installation happens earlier (even if the table already exists) and is handled by the delta function, the table should already be updated, so this code likely won't run. However, I think it's a good idea to keep it as a precaution.

google-listings-and-ads/src/DB/Table.php

Line 45 in 9f669d4

$this->wp->db_delta( $this->get_install_query() );

https://developer.wordpress.org/reference/functions/dbdelta/

[puntope]

LGTM

I see the new max_time created and populated correctly.