-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the language setting during onboarding #2522
Hide the language setting during onboarding #2522
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2458-streamline-onboarding #2522 +/- ##
=======================================================================
- Coverage 64.5% 63.8% -0.7%
=======================================================================
Files 795 326 -469
Lines 22844 5088 -17756
Branches 1220 1232 +12
=======================================================================
- Hits 14739 3247 -11492
+ Misses 7938 1673 -6265
- Partials 167 168 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct and I confirmed that the language field is now hidden on both the onboarding form and the Edit Free Listings screen after onboarding (/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&subpath=%2Ffree-listings%2Fedit
).
E2E tests are passing locally for me.
QA/Test Report- ✅Testing Environment -
Test Results - Changes working as expected. Onboarding flow works fine after new changes. Functional Demo / Screencast - Next Step- Ready to Code Review(Woo) Plugin file with this fix-specific branch: google-listings-and-ads.zip cc: @joemcgill for progress update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work and the change looks good.
Left a few suggestions about code no longer in use. It would be great if they could be removed as well.
js/src/components/free-listings/choose-audience-section/choose-audience-section.js
Show resolved
Hide resolved
js/src/components/free-listings/choose-audience-section/choose-audience-section.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Pushed 766e351 to update the tracking README file. |
bfe429d
into
feature/2458-streamline-onboarding
Changes proposed in this Pull Request:
Closes #2489 .
This PR hides the language settings UI during the onboarding steps.
Screenshots:
Detailed test instructions:
Additional details:
Update - Hides the language setting during onboarding
Changelog entry