2500: Show paid campaign setup fields during onboarding flow

[asvinb]

Changes proposed in this Pull Request:

Closes #2500 .

• Show all the setup fields by default.
• Removed all associated tests and helper files.

Screenshots:

Detailed test instructions:

1. Go through the onboarding flow again.
2. On the fourth step, i.e Create a campaign, the fields to create a campaign should be shown by default.
3. The "Skip this step for now" and "Create campaign" buttons should not be present.

Additional details:

Changelog entry

Tweak - Show campaign setup fields immediately during onboarding.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (5ec87d6) to head (068f4c4).
Report is 12 commits behind head on feature/2459-campaign-creation-flow.

Additional details and impacted files

@@                         Coverage Diff                         @@
##           feature/2459-campaign-creation-flow   #2533   +/-   ##
===================================================================
  Coverage                                 63.8%   63.8%           
===================================================================
  Files                                      326     326           
  Lines                                     5089    5089           
  Branches                                  1232    1232           
===================================================================
  Hits                                      3247    3247           
  Misses                                    1674    1674           
  Partials                                   168     168           

Flag	Coverage Δ
js-unit-tests	63.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[joemcgill]

@asvinb this is looking pretty good. Left a few suggestions.

[joemcgill]

Now that we're removing the possibility of skipping without opening the ads setup, this event prop should be removed from the whole component and removed from the inline docs for gla_onboarding_complete_button_click above.

I think we could also avoid the need to merge event props here and just set them directly when eventProps is initialized above.

[asvinb]

Good catch and makes sense @joemcgill . I've updated the PR. Can you kindly take a look again please?

[joemcgill]

Thanks for the updates. Sorry I missed that there were already separate tests for the second "Skip paid ads creation" button, your previous changes look correct.

[ankitguptaindia]

QA/Test Report- ✅

Testing Environment -

• WordPress: 6.6.1
• Theme active on store: Storefront Version: 4.6.0
• WooCommerce - Version 9.2.1
• PHP: 8.3
• Web Server: Nginx
• Browser: Chrome - Version 127
• OS: macOS Sonoma 14.6.1

Steps to Test- Please follow the steps mentioned in PR description and watch below attached screencast for all screens.

Test Results - Tested the changes in onboarding flow, and all scenarios are functioning as expected.

• UI Appearance: The interface displays as expected. ✅
• Console Errors: No errors were found in the browser console. ✅
• PHP Logs: The logs are clean, with no errors reported. ✅
• Onboarding Flow: Merchants can successfully complete the onboarding flow with new changes. ✅
• Onboarding Flow Merchants have the option to Skip paid ads creation ✅

Functional Demo / Screencast -

Recording.803.mp4

Next Step- Ready to Code Review(Woo)

Plugin file with this change related code:
google-listings-and-ads.zip

[joemcgill]

@eason9487 this one is ready for your review

[jorgemd24]

Hi @asvinb, I tested this locally, and it’s working well. I just have a question about the event props—previously, the default value was unknown for some of the properties, but now the behavior has changed. Let me know your thoughts. Thanks!

[joemcgill]

The updates seem ok to me. @eason9487 can you give it another look?

[eason9487]

LGTM

[joemcgill]

@asvinb can you take a look at the merge conflicts here?

[joemcgill]

Tested again after the merge conflicts were adjusted. Merging.