Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade readme details #2545

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Upgrade readme details #2545

merged 2 commits into from
Aug 20, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Aug 20, 2024

Changes proposed in this Pull Request:

This PR updates the details in the WPORG page

Context here: p1722256353475989-slack-C02BB3F30TG

Screenshots:

Screenshot 2024-08-20 at 11 37 16

Detailed test instructions:

  1. Check the readme in https://wordpress.org/plugins/developers/readme-validator/ (potentially you need to change the name because the validator doesn't support some keywords)
  2. Check the readme visually in https://wpreadme.com/ (especially faq)
  3. Copare it with https://woocommerce.com/products/google-listings-and-ads/ to see the details match between both pages

Additional details:

Changelog entry

Tweak - Upgrade readme details in WPORG

@puntope puntope self-assigned this Aug 20, 2024
@puntope puntope requested a review from a team August 20, 2024 07:39
@puntope puntope marked this pull request as ready for review August 20, 2024 07:39
@github-actions github-actions bot added the changelog: tweak Small change, that isn't actually very important. label Aug 20, 2024
eason9487
eason9487 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! LGTM.

The only comment is not a blocker.

readme.txt Outdated

Your products can also appear on Google Search, Google Images, and Gmail if you’re selling in the United States.
- **Access all the tools and features you need** to manage your WooCommerce store and grow your business— centralized in one place.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your business— centralized

The spaces before and after this em-dash are inconsistent.

@puntope puntope merged commit 5e9d973 into develop Aug 20, 2024
2 checks passed
@puntope puntope deleted the tweak/wporgpage-details branch August 20, 2024 10:28
@jorgemd24 jorgemd24 mentioned this pull request Aug 20, 2024
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eason9487 eason9487 eason9487 approved these changes

Assignees

@puntope puntope

Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puntope @eason9487