Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Budget Setup Card. #2552

Open
wants to merge 29 commits into
base: update/2535-consolidate-ad-creation-ccf-merged
Choose a base branch
from
Open

Update Budget Setup Card. #2552

wants to merge 29 commits into from
+348 −52

Commits on Aug 22, 2024

  1. Update Budget Setup Card.

    @ankitrox
    ankitrox committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a57bf14 View commit details
    Browse the repository at this point in the history

  2. Fix: e2e tests.

    @ankitrox
    ankitrox committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    273d02b View commit details
    Browse the repository at this point in the history

  3. Add e2e coverage.

    @ankitrox
    ankitrox committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9c30663 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. CR feedback - round 1.

    @ankitrox
    ankitrox committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    103ae13 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Fix: Step change shows no notice.

    @ankitrox
    ankitrox committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    096c086 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Fix: network error for budget recommendation.

    @ankitrox
    ankitrox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    76328ea View commit details
    Browse the repository at this point in the history

  2. Remove redundant code.

    @ankitrox
    ankitrox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8d9358d View commit details
    Browse the repository at this point in the history

  3. Update js doc.

    @ankitrox
    ankitrox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ea68ee8 View commit details
    Browse the repository at this point in the history

  4. Resolve conflicts and fix tests.

    @ankitrox
    ankitrox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    dcc6f73 View commit details
    Browse the repository at this point in the history

  5. Fix: lint issues.

    @ankitrox
    ankitrox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ac68177 View commit details
    Browse the repository at this point in the history

  6. Remove unused code.

    @ankitrox
    ankitrox committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    052783e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Resolve conflict with base branch.

    @ankitrox
    ankitrox committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c2fbf1a View commit details
    Browse the repository at this point in the history

  2. use fetch budget hook in paid-ads-setup-sections.

    @ankitrox
    ankitrox committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    61d73eb View commit details
    Browse the repository at this point in the history

  3. Remove redundant code.

    @ankitrox
    ankitrox committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f15bfb9 View commit details
    Browse the repository at this point in the history

  4. Display spinner till data gets loaded.

    @ankitrox
    ankitrox committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    85f5b35 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Add hook for code resuse.

    @ankitrox
    ankitrox committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    566476d View commit details
    Browse the repository at this point in the history

  2. Use hook.

    @ankitrox
    ankitrox committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dc7a4ac View commit details
    Browse the repository at this point in the history

  3. Stick to old UI/UX.

    @ankitrox
    ankitrox committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9ddfef4 View commit details
    Browse the repository at this point in the history

  4. Remove redundant code.

    @ankitrox
    ankitrox committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4af37a3 View commit details
    Browse the repository at this point in the history

  5. Pass recommendations prop.

    @ankitrox
    ankitrox committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1b92ecb View commit details
    Browse the repository at this point in the history

  6. Remove redundant code.

    @ankitrox
    ankitrox committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ab2db99 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'update/2535-consolidate-ad-creation-ccf-merged' into up… 

    …date/2502-budget-setup-card
    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    983438b View commit details
    Browse the repository at this point in the history

  2. Try not to use the useBudgetRecommendationData hook.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    eb18178 View commit details
    Browse the repository at this point in the history

  3. Add useFetchBudgetRecommendation hook.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    35716f0 View commit details
    Browse the repository at this point in the history

  4. Make use of new hook and add loading indicator.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0cafdb2 View commit details
    Browse the repository at this point in the history

  5. Remove unused hook.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    79ccefa View commit details
    Browse the repository at this point in the history

  6. Move clientSession.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fbde5f4 View commit details
    Browse the repository at this point in the history

  7. Restore complete campaign data from client session.

    @asvinb
    asvinb committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3ea1c12 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #2637 from woocommerce/update/2502-budget-setup-ca… 

    …rd-updates

Budget setup card updates after merge
    @joemcgill
    joemcgill authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f6f7ac3 View commit details
    Browse the repository at this point in the history