Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Linked accounts' to include Google Ads #2557

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kt-12
Copy link
Collaborator

@kt-12 kt-12 commented Aug 22, 2024

Changes proposed in this Pull Request:

Closes #2541.

Google Ads have been added to the description.

Screenshots:

Before:
Text: A WordPress.com account, Google account, and Google Merchant Center account are required to use this extension in WooCommerce.
image

After:
Text: A WordPress.com account, Google account, Google Merchant Center account, and Google Ads account are required to use this extension in WooCommerce.
Screenshot 2024-08-22 at 12 26 05

Detailed test instructions:

  1. Start onboarding process 1st step. Under Linked Accounts check the text.

Additional details:

Changelog entry

Tweak - Update the copy in the "Linked accounts" of the accounts connection setting to include Google Ads account.

@kt-12 kt-12 requested a review from joemcgill August 22, 2024 11:27
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.8%. Comparing base (d2c2acc) to head (af8c961).
Report is 51 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2557   +/-   ##
=======================================
  Coverage     63.8%   63.8%           
=======================================
  Files          326     326           
  Lines         5089    5089           
  Branches      1232    1232           
=======================================
  Hits          3247    3247           
  Misses        1674    1674           
  Partials       168     168           
Flag Coverage Δ
js-unit-tests 63.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 This one is fine to merge directly to develop once approved.

Copy link
Member

@ankitguptaindia ankitguptaindia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text has been updated. ✅

BEFORE AFTER
image image

@eason9487 eason9487 added the changelog: tweak Small change, that isn't actually very important. label Aug 23, 2024
@joemcgill
Copy link
Collaborator

@eason9487 I don't have permissions to merge to the develop branch. Can you merge this one? I think it's fine to go in early.

@eason9487 eason9487 merged commit 5f2c5b1 into develop Aug 23, 2024
9 checks passed
@eason9487 eason9487 deleted the tweek/2541-update-copy branch August 23, 2024 14:45
@tomalec tomalec mentioned this pull request Aug 27, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the copy on the settings screen to include the Google Ads account
4 participants