Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

Merged
merged 42 commits into from
Aug 23, 2024
Merged

Upgrade to use Node.js 20 and make components compatible with upgraded packages #2562

merged 42 commits into from
Aug 23, 2024

Commits on Aug 16, 2024

  1. Bump npm dependencies and upgrade to use Node.js v20.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8d6d98b View commit details
    Browse the repository at this point in the history

  2. Fix the build config of Fast Refresh mode.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b8b1129 View commit details
    Browse the repository at this point in the history

  3. Address Sass deprecation warnings. 

    Ref: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8dc4a94 View commit details
    Browse the repository at this point in the history

  4. Turn off the eslint rule react/react-in-jsx-scope.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    ddc2b96 View commit details
    Browse the repository at this point in the history

  5. Turn off the eslint rule jsdoc/check-line-alignment.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    f6997f7 View commit details
    Browse the repository at this point in the history

  6. Turn off the eslint rule import/no-named-as-default.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    23536a4 View commit details
    Browse the repository at this point in the history

  7. Resolve eslint errors for the @wordpress/i18n-text-domain rule.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    cdd9aab View commit details
    Browse the repository at this point in the history

  8. Resolve eslint errors that can be automatically fixed. 

    Fixed by running `npm run lint:js -- --fix`.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c41ef64 View commit details
    Browse the repository at this point in the history

  9. Resolve eslint errors for the jsdoc/no-undefined-types rule.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    67ef0e2 View commit details
    Browse the repository at this point in the history

  10. Resolve eslint errors for the import/no-unresolved rule.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c4db2a3 View commit details
    Browse the repository at this point in the history

  11. Resolve eslint errors for the no-redeclare rule.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6997b6f View commit details
    Browse the repository at this point in the history

  12. Resolve eslint errors for the jsdoc/require-yields-check rule.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    47d1f9f View commit details
    Browse the repository at this point in the history

  13. Resolve eslint errors for the `@typescript-eslint/no-use-before-defin… 

    …e` rule.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    9886344 View commit details
    Browse the repository at this point in the history

  14. Resolve eslint errors for the jsdoc/tag-lines rule.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    fccc0cd View commit details
    Browse the repository at this point in the history

  15. Jest: Fix that [email protected] doesn't provide the CommonJS build.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    6fb9a6c View commit details
    Browse the repository at this point in the history

  16. Jest: Force 'uuid' to resolve with the CommonJS entry point as jest d… 

    …oesn't support `package.json.exports`.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d5de474 View commit details
    Browse the repository at this point in the history

  17. Jest: Fix @woocommerce/components still using incompatible `@woocom… 

    …merce/currency`.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    964e769 View commit details
    Browse the repository at this point in the history

  18. Jest: Ignore that 'qrcode.react' module is incorrectly listed in dev … 

    …dependencies of '@automattic/components'.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    d8b3d7a View commit details
    Browse the repository at this point in the history

  19. Jest: Fix the React versioning conflicts between @wordpress/* and `… 

    …@woocommerce/*`.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    76c1efa View commit details
    Browse the repository at this point in the history

  20. Jest: Update timer mocks to deprecate the timers option.

    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e9cbf6a View commit details
    Browse the repository at this point in the history

  21. Jset: Migrate test cases to @testing-library/user-event v14. 

    Migration includes:
- Invoke `userEvent.setup()` in the test itself and before the component is rendered.
- Adding `async` and `await` as all APIs are asynchronous.
- No need to be wrapped in `act`.
- Replace the simulation of pressing buttons with the `keyboard` API.
- `clear()` is changed to only support editable elements only.
    @eason9487
    eason9487 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    da344e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Resolve eslint errors for the `testing-library/no-wait-for-multiple-a… 

    …ssertions` rule.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    38d4563 View commit details
    Browse the repository at this point in the history

  2. Resolve eslint errors for the testing-library/no-unnecessary-act rule.

    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b634d9e View commit details
    Browse the repository at this point in the history

  3. Jest: Prevent form submission during testing.

    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    def9cb0 View commit details
    Browse the repository at this point in the history

  4. Jest: The ARIA role of <img> is considered as presentation if its… 

    … `alt` is an empty string.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    45f90a7 View commit details
    Browse the repository at this point in the history

  5. Jest: Prevent the <Dashboard> tests from calling window.fetch.

    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d5e5324 View commit details
    Browse the repository at this point in the history

  6. Jest: Adjust <Stepper> related tests to wait for stepper content to… 

    … be rendered.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ad1daac View commit details
    Browse the repository at this point in the history

  7. Jest: Update snapshots to reflect the format changes.

    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b7c6eca View commit details
    Browse the repository at this point in the history

  8. Jest: Fix CampaignNameCell tests by replacing fireEvent with `use… 

    …rEvent`.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a89e0b2 View commit details
    Browse the repository at this point in the history

  9. Jest: Ignore the deprecation warnings of defaultProps from React by… 

    … calling `console.error()`.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0686dc9 View commit details
    Browse the repository at this point in the history

  10. Jest: Remove the structuredClone polyfill no longer needed.

    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9df6ee1 View commit details
    Browse the repository at this point in the history

  11. Make <AppTooltip> compatible with the placement prop introduced b… 

    …y WordPress 6.4 to replace `position`.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    757b5c9 View commit details
    Browse the repository at this point in the history

  12. Rewrite the replacer of JSON.stringify in getReportKey to ensure … 

    …it returns the same key regardless of the query keys' order.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    940649d View commit details
    Browse the repository at this point in the history

  13. Replace deprecated event.keyCode with event.code for `<Verificati… 

    …onCodeControl>`.

Ref: #1098
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8554c2d View commit details
    Browse the repository at this point in the history

  14. Avoid accidentally using the event object to reset the asset group in… 

    … `<CampaignAssetsForm>`.
    @eason9487
    eason9487 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e2b305f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Add code document for the replacer function in js/src/data/utils.js. 

    Address: #2544 (comment)
    @eason9487
    eason9487 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    69fc1b4 View commit details
    Browse the repository at this point in the history

  2. Add a more detailed description for the mock isWpVersion function. 

    Ref: #2544 (comment)
    @eason9487
    eason9487 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c9a259f View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Allow npm ^9 because dependabot is using an npm version that doesn'… 

    …t pair with Node.js 20.

Address: #2517 (comment)
    @eason9487
    eason9487 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b2a3d13 View commit details
    Browse the repository at this point in the history

  2. Add a more detailed code comment to the jsdoc/no-undefined-types es… 

    …lint rule.

Ref: #2517 (comment)
    @eason9487
    eason9487 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c76514b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2517 from woocommerce/dev/2002-use-nodejs-20 

    Upgrade to use Node.js 20 and bump npm dependencies
    @eason9487
    eason9487 authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7316de3 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2544 from woocommerce/tweak/2002-jest-for-nodejs-… 

    …20-and-compatible-wp-wc

Migrate jest tests to use Node.js 20 and make components compatible with upgraded packages
    @eason9487
    eason9487 authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b22d9c6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into dev/use-nodejs-20

    @eason9487
    eason9487 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e46bd2e View commit details
    Browse the repository at this point in the history