Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2537: Swap performance cards. #2564

Conversation

asvinb
Copy link
Collaborator

@asvinb asvinb commented Aug 23, 2024

Changes proposed in this Pull Request:

Closes #2537

Replace this with a good description of your changes & reasoning.

Screenshots:

image

Detailed test instructions:

  1. Go to the dashboard.
  2. Check the order and title of the cards are as per the AC.

Additional details:

Changelog entry

Tweak - Swap performance cards on the Dashboard page.

@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.8%. Comparing base (315fce2) to head (5c62798).
Report is 2 commits behind head on feature/2460-google-ads-value-prop.

Files with missing lines Patch % Lines
js/src/dashboard/summary-section/index.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##             feature/2460-google-ads-value-prop   #2564      +/-   ##
=======================================================================
- Coverage                                  65.0%   63.8%    -1.2%     
=======================================================================
  Files                                       475     326     -149     
  Lines                                     17900    5089   -12811     
  Branches                                      0    1232    +1232     
=======================================================================
- Hits                                      11640    3247    -8393     
+ Misses                                     6260    1674    -4586     
- Partials                                      0     168     +168     
Flag Coverage Δ
js-unit-tests 63.8% <50.0%> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
js/src/dashboard/summary-section/index.js 81.2% <50.0%> (ø)

... and 800 files with indirect coverage changes

@joemcgill joemcgill linked an issue Aug 26, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Tested locally and am seeing the correct sections.

@ankitguptaindia
Copy link
Member

QA/Test Report-

Testing Environment -

  • WordPress: 6.6.1
  • Theme active on store: Twenty Twenty-Four Version: 1.2
  • WooCommerce - Version 9.2.3
  • PHP: 8.3
  • Web Server: Nginx
  • Browser: Chrome - Version 127
  • OS: macOS Sonoma 14.6.1

Test Results - Changes are working as expected.

Functional Demo / Screencast -

image

Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eason9487 eason9487 added changelog: tweak Small change, that isn't actually very important. and removed changelog: update Big changes to something that wasn't broken. labels Sep 4, 2024
@joemcgill joemcgill merged commit 0423844 into feature/2460-google-ads-value-prop Sep 4, 2024
10 checks passed
@joemcgill joemcgill deleted the update/2537-swap-dashboard-cards branch September 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: tweak Small change, that isn't actually very important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap and rename dashboard performance cards
4 participants