Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum budget limit #2583

Merged

Rename prop to recommendedDailyBudget.

9dd2744
Select commit
Loading
Failed to load commit list.
Merged

Add minimum budget limit #2583

Rename prop to recommendedDailyBudget.
9dd2744
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2024 in 1s

63.1% (+0.5%) compared to 1626f8a

View this Pull Request on Codecov

63.1% (+0.5%) compared to 1626f8a

Details

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 63.1%. Comparing base (1626f8a) to head (9dd2744).

Files with missing lines Patch % Lines
js/src/pages/edit-paid-ads-campaign/index.js 0.0% 4 Missing and 1 partial ⚠️
js/src/components/paid-ads/campaign-assets-form.js 66.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2583     +/-   ##
=====================================================================
+ Coverage                                 62.6%   63.1%   +0.5%     
=====================================================================
  Files                                      329     329             
  Lines                                     5166    5183     +17     
  Branches                                  1254    1262      +8     
=====================================================================
+ Hits                                      3232    3268     +36     
+ Misses                                    1752    1735     -17     
+ Partials                                   182     180      -2     
Files with missing lines Coverage Δ
js/src/components/paid-ads/validateCampaign.js 100.0% <100.0%> (ø)
js/src/pages/create-paid-ads-campaign/index.js 10.0% <ø> (ø)
js/src/setup-ads/ads-stepper/setup-paid-ads.js 62.1% <ø> (ø)
js/src/components/paid-ads/campaign-assets-form.js 76.9% <66.7%> (-0.9%) ⬇️
js/src/pages/edit-paid-ads-campaign/index.js 8.6% <0.0%> (-0.6%) ⬇️

... and 6 files with indirect coverage changes