Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding: Clean up unused MC settings data #2584

Closed
wants to merge 2 commits into from
Closed

Onboarding: Clean up unused MC settings data #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd40752
remove redundent setting
kt-12 Sep 5, 2024
504167a
cs fixes
kt-12 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions js/src/components/free-listings/setup-free-listings/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,7 @@ const targetAudienceFields = [ 'locale', 'language', 'location', 'countries' ];
*
* If we are adding a new settings field, it should be added into this array.
*/
const settingsFieldNames = [
'shipping_rate',
'shipping_time',
'tax_rate',
'website_live',
'checkout_process_secure',
'payment_methods_visible',
'refund_tos_visible',
'contact_info_visible',
];
const settingsFieldNames = [ 'shipping_rate', 'shipping_time', 'tax_rate' ];

/**
* Get settings object from Form values.
Expand Down Expand Up @@ -214,11 +205,6 @@ const SetupFreeListings = ( {
shipping_rate: settings.shipping_rate,
shipping_time: settings.shipping_time,
tax_rate: settings.tax_rate,
website_live: settings.website_live,
checkout_process_secure: settings.checkout_process_secure,
payment_methods_visible: settings.payment_methods_visible,
refund_tos_visible: settings.refund_tos_visible,
contact_info_visible: settings.contact_info_visible,
// This is used in UI only, not used in API.
offer_free_shipping:
getOfferFreeShippingInitialValue( shippingRates ),
Expand Down
5 changes: 0 additions & 5 deletions js/src/data/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ import { isWCIos, isWCAndroid } from '.~/utils/isMobileApp';
* @property {'automatic'|'flat'|'manual'} [shipping_rate] Type of the shipping rate.
* @property {'flat'|'manual'} [shipping_time] Type of the shipping time.
* @property {string|null} [tax_rate] Type of tax rate, There are two possible values if US is selected: 'destination' and 'manual' otherwise will be null.
* @property {boolean} [website_live] Whether the store website is live.
* @property {boolean} [checkout_process_secure] Whether the checkout process is complete and secure.
* @property {boolean} [payment_methods_visible] Whether the payment methods are visible on the website.
* @property {boolean} [refund_tos_visible] Whether the refund policy and terms of service are visible on the website.
* @property {boolean} [contact_info_visible] Whether the phone number, email, and/or address are visible on the website.
*/

/**
Expand Down