Remove the accounts connection page from the Ads Setup flow.

[kt-12]

Changes proposed in this Pull Request:

Closes #2534.

Replace this with a good description of your changes & reasoning.

Screenshots:

After removal of accounts setup page.

Detailed test instructions:

1. Delete gla_ads_setup_completed_at options.
2. Go to dashboard, under Performance (Paid Campaigns) section click Add paid campaign
3. You should not see the Setup accounts page as shown in the screenshot. Proceed with the other steps and see if you are able to create first paid campaign.

Additional details:

Changelog entry

Update - When the accounts have been connected before, skip their setup step during the Ads-onboarding.

[asvinb]

@kt-12 Can you please do the following:

• Change the target branch for your PR to feature/2460-simplify-paid-ads-setup as per the IB.
• Fix the linting errors.
• Review the E2E tests. For e.g there's empty tests for Set up your accounts page in tests/e2e/specs/add-paid-campaigns/add-paid-campaigns.test.js

[codecov]

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.8%. Comparing base (425c6e3) to head (9eaff54).

Files with missing lines	Patch %	Lines
js/src/setup-ads/ads-stepper/index.js	68.8%	5 Missing ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2595     +/-   ##
=====================================================================
+ Coverage                                 62.1%   62.8%   +0.7%     
=====================================================================
  Files                                      327     328      +1     
  Lines                                     5109    5131     +22     
  Branches                                  1244    1251      +7     
=====================================================================
+ Hits                                      3171    3220     +49     
+ Misses                                    1756    1731     -25     
+ Partials                                   182     180      -2     

Flag	Coverage Δ
js-unit-tests	62.8% <68.8%> (+0.7%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
js/src/setup-ads/ads-stepper/index.js	83.3% <68.8%> (-16.7%)	⬇️

... and 7 files with indirect coverage changes

[asvinb]

Changes LGTM @kt-12

[ankitguptaindia]

QA/Test Report- ✅

Testing Environment -

• WordPress: 6.6.2
• Theme active on store: Twenty Twenty-Four Version: 1.2
• WooCommerce - Version 9.3.2
• PHP: 8.3
• Web Server: Nginx
• Browser: Chrome - Version 128
• OS: macOS Sonoma 14.6.1

Test Results - Tested the functionally of the new changes. Working as described in scope. ✅

Functional Demo / Screencast -

GLNA.mp4

Next Step- Ready to Code Review(Woo)

[eason9487]

In addition to the comments left, there are two other issues:

• The merge base should be the feature/2460-simplify-paid-ads-setup branch rather than develop.
• The e2e testing failed: https://github.com/woocommerce/google-listings-and-ads/actions/runs/11029983509/job/30633596790

[kt-12]

@eason9487 I have addressed your review comment. I have also fixed E2E to reflect the current flow.

[joemcgill]

@kt-12, I've made a few adjustments in 64051b6, which fixes some JSLint issues but more importantly checks the step value from the ads/account-status request rather than the step being used in this component to control the currentStep of the Stepper being rendered.

I think this looks good now, but would like to see if @ankitguptaindia can give this another test and confirm that the issues @eason9487 shared here can no longer be reproduced when a new account is created and claimed while this screen is closed.

[ankitguptaindia]

I think this looks good now, but would like to see if @ankitguptaindia can give this another test and confirm that the issues @eason9487 shared #2595 (comment) can no longer be reproduced when a new account is created and claimed while this screen is closed.

@joemcgill Tested the reported issue and performed the cases when a new account is created and claimed while this screen is closed. It is working as expected and not able to reproduce the issue now. Tested others that are related to the main changes in this PR.

[joemcgill]

This needs a refresh after #2577 was merged to the feature branch

[kt-12]

@joemcgill I have handled merge conflict. This is good for WooReview.

[ankitguptaindia]

@kt-12 When we click on the ‘Add paid campaign’ button, it takes a few seconds to show campaign creation fields (the page looks blank for a moment).
Please refer- https://somup.com/cZ62DhHtJN

Please let me know if we are fixing this issue on another PR.

[kt-12]

@joemcgill this is good for review. I have moved final fixes to jest here so with this merging we will also close 2579.

[joemcgill]

I've tested several scenarios and the card refresh looks much better now. Thanks, @kt-12