Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kickoff MC and Ads account creation #2618

Update JSDoc.

8ab1be0
Select commit
Loading
Failed to load commit list.
Merged

Kickoff MC and Ads account creation #2618

Update JSDoc.
8ab1be0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 28, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 80.64516% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/2509-consolidate-google-account-cards@7d31e5c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
js/src/hooks/useGoogleMCAccount.js 12.5% 6 Missing and 1 partial ⚠️
js/src/hooks/useAutoCreateAdsMCAccounts.js 93.8% 3 Missing ⚠️
js/src/hooks/useExistingGoogleAdsAccounts.js 0.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                               @@
##             feature/2509-consolidate-google-account-cards   #2618   +/-   ##
===============================================================================
  Coverage                                                 ?   62.7%           
===============================================================================
  Files                                                    ?     324           
  Lines                                                    ?    5153           
  Branches                                                 ?    1259           
===============================================================================
  Hits                                                     ?    3232           
  Misses                                                   ?    1744           
  Partials                                                 ?     177           
Files with missing lines Coverage Δ
.../components/google-combo-account-card/constants.js 100.0% <100.0%> (ø)
js/src/constants.js 100.0% <100.0%> (ø)
js/src/hooks/useCreateMCAccount.js 6.7% <ø> (ø)
js/src/hooks/useExistingGoogleAdsAccounts.js 16.7% <0.0%> (ø)
js/src/hooks/useAutoCreateAdsMCAccounts.js 93.8% <93.8%> (ø)
js/src/hooks/useGoogleMCAccount.js 13.3% <12.5%> (ø)