Hide GTIN field for new installs make readonly for existing installs
#2622
Conversation
…ed and what version of WC is installed
github-actions
bot
added
the
changelog: update
martynmjones
changed the base branch from
develop
to
add/support-core-gtin-field
| public function set_readonly( $value = false ) { | ||
| $this->is_readonly = $value; | ||
|
|
||
| return $this; | ||
| } | ||
| /** | ||
| * @param bool $value | ||
| * | ||
| * @return InputInterface | ||
| */ | ||
| public function set_disabled( $value = false ) { | ||
| $this->is_disabled = $value; | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
WDYT of adding the types in the arguments and signature fore these 2?
public function set_readonly(bool $value = false ): InputInterface
There was a problem hiding this comment.
Another concern I have is that disabled is the right name to use for a hidden field. As in HTML disabled inputs are still readable. So I would suggest is_hidden / set_hidden but not a blocker tho, just following the naming for PR name and issue description:
... GTIN field in Google for WooCommerce will need to be hidden for new users of the extension and made read-only for existing users...
| * | ||
| * @var string | ||
| */ | ||
| private $hidden_from = '2.8.5'; |
There was a problem hiding this comment.
COuld we add the keyword version somewhere in this field, also should this be a constant instead?
| protected function gla_installed_after( $date ): bool { | ||
| $gla_installed = $this->options->get( OptionsInterface::INSTALL_TIMESTAMP, false ); | ||
|
|
||
| if ( false === $gla_installed ) { | ||
| return false; | ||
| } | ||
|
|
||
| return ( $gla_installed >= strtotime( $date ) ); | ||
| } |
| @@ -60,6 +73,9 @@ class Input extends Form implements InputInterface { | |||
| public function __construct( string $type, string $block_name ) { | |||
| $this->type = $type; | |||
| $this->block_name = $block_name; | |||
|
|
|||
| $this->set_options_object( woogle_get_container()->get( OptionsInterface::class ) ); | |||
There was a problem hiding this comment.
Do we need to instantiate the container in all the inputs? Maybe we can just do this in GTIN?
Changes proposed in this Pull Request:
Adds restrictions to the
GTINfield in Google for WooCommerce depending on the version of WooCommerce installed and what version of Google for WooCommerce was first installed.The following conditions apply:
9.2.0or higher is installed and Google for WooCommerce is installed for the first time theGTINfield in G4W is hidden9.2.0or higher is installed and Google for WooCommerce had already been installed on a website then theGTINfield in G4W is read-only9.2.0is installed then theGTINfield in G4W continues to function as it previously didAdditionally, a new option is added called
INSTALL_VERSIONfor tracking what version of Google for WooCommerce was first installed on a website 43a76c3.Closes #2615
Screenshots:
Detailed test instructions:
update/2615-hide-gtin-for-new-users-make-readonly-for-exisitngon a site with WC9.1.0installed that has already onboarded with Google for WooCommerceGTINfield is available on theGoogle for WooCommercetab9.2.0or higherGTINfield is read-only and the tooltip directs merchants to theInventorytabwp option update gla_install_version 2.8.4GTINfield is not displayed on theGoogle for WooCommercetab when editing a productChangelog entry