Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2535: Consolidate Ad Creation #2623

Open
wants to merge 44 commits into
base: feature/2459-campaign-creation-flow
Choose a base branch
from
Open

2535: Consolidate Ad Creation #2623

wants to merge 44 commits into from

Commits on Aug 29, 2024

  1. Move PaidAdsFeaturesSection and PaidAdsSetupSections components.

    @asvinb
    asvinb committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b207569 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Save Work in progress.

    @asvinb
    asvinb committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f65fbee View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Consolidate AdsCampaign component.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1b8abc9 View commit details
    Browse the repository at this point in the history

  2. Revert local test changes.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3f8ac23 View commit details
    Browse the repository at this point in the history

  3. Remove comments.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    101412b View commit details
    Browse the repository at this point in the history

  4. Clean up comments.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    620b183 View commit details
    Browse the repository at this point in the history

  5. Remove unused imports.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    84879b8 View commit details
    Browse the repository at this point in the history

  6. Editing a campaign working.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a3b50fe View commit details
    Browse the repository at this point in the history

  7. Fix condition to render paid ads sections.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a9b7f13 View commit details
    Browse the repository at this point in the history

  8. Address linting errors.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c76a128 View commit details
    Browse the repository at this point in the history

  9. Add headerDescription prop.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dcea1d6 View commit details
    Browse the repository at this point in the history

  10. Remove unused comment.

    @asvinb
    asvinb committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    522e635 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Remove onClick prop (?)

    @asvinb
    asvinb committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    388fddb View commit details
    Browse the repository at this point in the history

  2. Show banner in create mode only.

    @asvinb
    asvinb committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8ddde21 View commit details
    Browse the repository at this point in the history

  3. Remove unused event prop

    @asvinb
    asvinb committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ff7f281 View commit details
    Browse the repository at this point in the history

  4. Remove unecessary isCreation prop.

    @asvinb
    asvinb committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5200727 View commit details
    Browse the repository at this point in the history

  5. Add countryCodes field.

    @asvinb
    asvinb committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d93bc1d View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Remove country code from edit screen.

    @asvinb
    asvinb committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8e95434 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'feature/2459-campaign-creation-flow' into update/2535-c… 

    …onsolidate-ad-creation-ccf-merged
    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2fa2bdb View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add modal changes.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6dd25e8 View commit details
    Browse the repository at this point in the history

  2. Show paid ads sections by default.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2f91ae8 View commit details
    Browse the repository at this point in the history

  3. Simplify forms more.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3418caa View commit details
    Browse the repository at this point in the history

  4. Move setup paid ads component.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7f25ff7 View commit details
    Browse the repository at this point in the history

  5. Remove unused braces.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7db2664 View commit details
    Browse the repository at this point in the history

  6. Revert debugging changes.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    892c016 View commit details
    Browse the repository at this point in the history

  7. Fix tests for setup paid ads.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9ba6eed View commit details
    Browse the repository at this point in the history

  8. Remove unused args.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d7d5c6a View commit details
    Browse the repository at this point in the history

  9. Fix hook return value.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9c576b0 View commit details
    Browse the repository at this point in the history

  10. Revert change.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c790719 View commit details
    Browse the repository at this point in the history

  11. Revert change.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    35fed8a View commit details
    Browse the repository at this point in the history

  12. Set up events correctly.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fbce5c6 View commit details
    Browse the repository at this point in the history

  13. Updated JSDocs.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    814e353 View commit details
    Browse the repository at this point in the history

  14. Remove unused files.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    17a869d View commit details
    Browse the repository at this point in the history

  15. Check for approval notice.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ca3dc21 View commit details
    Browse the repository at this point in the history

  16. Update condition to show campaign preview card.

    @asvinb
    asvinb committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d4b6a8d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Use CampaignAssetsForm within SetupPaidAds.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    38d255a View commit details
    Browse the repository at this point in the history

  2. Do not load amount from local storage all the time except during onbo… 

    …arding.
    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5343963 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/2458-streamline-onboarding' into update/2535-co… 

    …nsolidate-ad-creation-ccf-onboarding-merged
    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    face49e View commit details
    Browse the repository at this point in the history

  4. Fix merge conflict for AdsCampaign.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b3e3b2a View commit details
    Browse the repository at this point in the history

  5. Fix merge conflict for audienceSection test.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d4c376d View commit details
    Browse the repository at this point in the history

  6. Delete unused file.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7cd8c5b View commit details
    Browse the repository at this point in the history

  7. fix linting issues.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5d727ba View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge pull request #2627 from woocommerce/update/2535-consolidate-ad-… 

    …creation-ccf-onboarding-merged

Merge onboarding improvements branch into consolidated ad
    @joemcgill
    joemcgill authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ab1f837 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/2459-campaign-creation-flow' into update/2535-c… 

    …onsolidate-ad-creation-ccf-merged
    @joemcgill
    joemcgill committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    34c53d7 View commit details
    Browse the repository at this point in the history