Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update budget recommendation text #2629

Open
wants to merge 8 commits into
base: feature/2459-campaign-creation-flow
Choose a base branch
from

Conversation

kt-12
Copy link
Collaborator

@kt-12 kt-12 commented Sep 30, 2024

Changes proposed in this Pull Request:

Closes #2600 .

Text updated to reflect the change. Check screenshot.

Screenshots:

Multiple Counties selected
Screenshot 2024-09-30 at 10 42 21

Single country selected
Screenshot 2024-09-30 at 10 42 13

Detailed test instructions:

  1. On "Create your paid campaign" page select single country
  2. Check if the text change is reflected.
  3. Now select an additional country and see if the text is same as shown in the screenshot above.

Additional details:

Changelog entry

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.7%. Comparing base (1c6a902) to head (b1f9944).
Report is 15 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2629      +/-   ##
============================================
- Coverage       65.3%   62.7%    -2.6%     
============================================
  Files            474     319     -155     
  Lines          17893    5074   -12819     
  Branches           0    1231    +1231     
============================================
- Hits           11685    3180    -8505     
+ Misses          6208    1721    -4487     
- Partials           0     173     +173     
Flag Coverage Δ
js-unit-tests 62.7% <ø> (?)
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-ads/budget-section/budget-recommendation/index.js 4.0% <ø> (ø)

... and 792 files with indirect coverage changes

@asvinb
Copy link
Collaborator

asvinb commented Sep 30, 2024

LGTM @kt-12

@joemcgill joemcgill changed the base branch from develop to feature/2459-campaign-creation-flow September 30, 2024 19:59
@ankitguptaindia
Copy link
Member

Changes Look good and working as expected. ✅

Recording.883.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review budget recommendation text
5 participants