-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update budget recommendation text #2629
Open
kt-12
wants to merge
8
commits into
feature/2459-campaign-creation-flow
Choose a base branch
from
enhancement/2600-update-budget-text
base: feature/2459-campaign-creation-flow
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update budget recommendation text #2629
kt-12
wants to merge
8
commits into
feature/2459-campaign-creation-flow
from
enhancement/2600-update-budget-text
+57
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-issue PHP Units tests: Symlink WC instead of moving the WC folder
[API PULL] Tweak WP Proxy Response to force the types of the price fields
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2629 +/- ##
============================================
- Coverage 65.3% 62.7% -2.6%
============================================
Files 474 319 -155
Lines 17893 5074 -12819
Branches 0 1231 +1231
============================================
- Hits 11685 3180 -8505
+ Misses 6208 1721 -4487
- Partials 0 173 +173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asvinb
approved these changes
Sep 30, 2024
LGTM @kt-12 |
joemcgill
changed the base branch from
develop
to
feature/2459-campaign-creation-flow
September 30, 2024 19:59
Changes Look good and working as expected. ✅ Recording.883.mp4 |
ankitguptaindia
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2600 .
Text updated to reflect the change. Check screenshot.
Screenshots:
Multiple Counties selected
Single country selected
Detailed test instructions:
Additional details:
Changelog entry