Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2460 google ads value prop #2635

Draft
wants to merge 104 commits into
base: feature/2459-campaign-creation-flow
Choose a base branch
from

Merge pull request #2672 from woocommerce/update/2664-remove-paid-word

98c62a5
Select commit
Loading
Failed to load commit list.
Draft

Feature/2460 google ads value prop #2635

Merge pull request #2672 from woocommerce/update/2664-remove-paid-word
98c62a5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 17, 2024 in 0s

63.6% (+0.3%) compared to 355487b

View this Pull Request on Codecov

63.6% (+0.3%) compared to 355487b

Details

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.6%. Comparing base (355487b) to head (98c62a5).

Files with missing lines Patch % Lines
...c/dashboard/summary-section/paid-features/index.js 16.7% 5 Missing ⚠️
js/src/dashboard/summary-section/index.js 66.7% 2 Missing ⚠️
...product-statistics/create-campaign-notice/index.js 77.8% 2 Missing ⚠️
...src/components/paid-ads/asset-group/asset-group.js 0.0% 1 Missing ⚠️
...rd/summary-section/paid-campaign-promotion-card.js 0.0% 1 Missing ⚠️
...rd/summary-section/paid-features/free-ad-credit.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/2459-campaign-creation-flow   #2635     +/-   ##
=====================================================================
+ Coverage                                 63.3%   63.6%   +0.3%     
=====================================================================
  Files                                      330     332      +2     
  Lines                                     5205    5210      +5     
  Branches                                  1269    1265      -4     
=====================================================================
+ Hits                                      3294    3315     +21     
+ Misses                                    1731    1718     -13     
+ Partials                                   180     177      -3
Files with missing lines Coverage Δ
...rc/components/paid-ads/add-paid-campaign-button.js 73.3% <100.0%> (ø)
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% <ø> (ø)
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% <ø> (ø)
...-program-button/edit-program-prompt-modal/index.js 10.0% <ø> (ø)
...e-card/program-toggle/pause-program-modal/index.js 14.3% <ø> (ø)
...emove-program-button/remove-program-modal/index.js 7.1% <ø> (ø)
...dashboard/campaign-creation-success-guide/index.js 71.4% <ø> (ø)
js/src/pages/create-paid-ads-campaign/index.js 10.0% <ø> (ø)
js/src/pages/edit-paid-ads-campaign/index.js 8.6% <ø> (ø)
js/src/product-feed/product-statistics/index.js 95.7% <ø> (ø)
... and 9 more

... and 2 files with indirect coverage changes

View more details on Codecov