Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Ads value prop in Paid Campaign performance card #2650

Merged

remove size attribute.

1a516c7
Select commit
Loading
Failed to load commit list.
Merged

Show Ads value prop in Paid Campaign performance card #2650

remove size attribute.
1a516c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 1s

63.6% (+0.1%) compared to e7a0f64

View this Pull Request on Codecov

63.6% (+0.1%) compared to e7a0f64

Details

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.6%. Comparing base (e7a0f64) to head (1a516c7).

Files with missing lines Patch % Lines
...c/dashboard/summary-section/paid-features/index.js 16.7% 5 Missing ⚠️
js/src/dashboard/summary-section/index.js 80.0% 1 Missing ⚠️
...rd/summary-section/paid-campaign-promotion-card.js 0.0% 1 Missing ⚠️
...rd/summary-section/paid-features/free-ad-credit.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                          @@
##           feature/2460-google-ads-value-prop   #2650     +/-   ##
====================================================================
+ Coverage                                63.5%   63.6%   +0.1%     
====================================================================
  Files                                     331     332      +1     
  Lines                                    5214    5210      -4     
  Branches                                 1273    1265      -8     
====================================================================
+ Hits                                     3313    3315      +2     
+ Misses                                   1723    1718      -5     
+ Partials                                  178     177      -1     
Files with missing lines Coverage Δ
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% <ø> (ø)
js/src/dashboard/summary-section/index.js 78.9% <80.0%> (-2.3%) ⬇️
...rd/summary-section/paid-campaign-promotion-card.js 0.0% <0.0%> (-9.1%) ⬇️
...rd/summary-section/paid-features/free-ad-credit.js 50.0% <50.0%> (ø)
...c/dashboard/summary-section/paid-features/index.js 16.7% <16.7%> (ø)