Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding: Create new ads account. #2651

Merged
merged 54 commits into from
Nov 13, 2024
Merged

Onboarding: Create new ads account. #2651

merged 54 commits into from
Nov 13, 2024

Commits on Oct 25, 2024

  1. Create new ads account.

    @ankitrox
    ankitrox committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5b64b6b View commit details
    Browse the repository at this point in the history

  2. Fix: lint css.

    @ankitrox
    ankitrox committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fdccdfb View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'update/2596-connect-ads-account' into update/2603-creat… 

    …e-ads-account
    @ankitrox
    ankitrox committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ab8984e View commit details
    Browse the repository at this point in the history

  2. Add css.

    @ankitrox
    ankitrox committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d4e0142 View commit details
    Browse the repository at this point in the history

  3. Do not show card if account is in unclaimed status.

    @ankitrox
    ankitrox committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1584e33 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'update/2596-connect-ads-account' into update/2603-creat… 

    …e-ads-account
    @ankitrox
    ankitrox committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a00d42c View commit details
    Browse the repository at this point in the history

  5. Add E2E tests.

    @ankitrox
    ankitrox committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    54fdfc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Fix: E2E issues.

    @ankitrox
    ankitrox committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b25965 View commit details
    Browse the repository at this point in the history

  2. Resolve conflicts in E2E.

    @ankitrox
    ankitrox committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    86a174e View commit details
    Browse the repository at this point in the history

  3. Resolve conflicts.

    @ankitrox
    ankitrox committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e1fca96 View commit details
    Browse the repository at this point in the history

  4. CR feedback.

    @ankitrox
    ankitrox committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    073b04f View commit details
    Browse the repository at this point in the history

  5. Resolve conflicts.

    @ankitrox
    ankitrox committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    863a71c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'update/2596-connect-ads-account' into update/2603-creat… 

    …e-ads-account
    @ankitrox
    ankitrox committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e9a071b View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Show correct text when creating an account.

    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3e2dcbe View commit details
    Browse the repository at this point in the history

  2. Revert change.

    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    db10842 View commit details
    Browse the repository at this point in the history

  3. Prevent complete re rendering of the card.

    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3e4249c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0c3f1c7 View commit details
    Browse the repository at this point in the history

  5. Fix error.

    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f31dcc4 View commit details
    Browse the repository at this point in the history

  6. Fetch existing accounts again.

    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    46aef1c View commit details
    Browse the repository at this point in the history

  7. Display updating text only when clicking the claim button.

    @asvinb
    asvinb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b93f3aa View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Save WIP.

    @asvinb
    asvinb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d3dae92 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/2509-consolidate-google-account-cards' into upd… 

    …ate/2603-create-ads-account
    @asvinb
    asvinb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9f335dd View commit details
    Browse the repository at this point in the history

  3. Save WIP.

    @asvinb
    asvinb committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3c19aa9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. UX improvements.

    @asvinb
    asvinb committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    90db787 View commit details
    Browse the repository at this point in the history

  2. Review comments.

    @asvinb
    asvinb committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    797ea87 View commit details
    Browse the repository at this point in the history

  3. Use single quotes.

    @asvinb
    asvinb committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    74ff220 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e6222de View commit details
    Browse the repository at this point in the history

  5. Use correct class name.

    @asvinb
    asvinb committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2d9c2cf View commit details
    Browse the repository at this point in the history

  6. Improve 'Connect Google account' E2E tests 

    This eliminates some unnecessary page.goto() calls to speed up the tests and reduce some inconsistencies.
    @joemcgill
    joemcgill committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5638687 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Update title and indicator label.

    @asvinb
    asvinb committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6bb4318 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'update/2603-create-ads-account' of github.com:woocommer… 

    …ce/google-listings-and-ads into update/2603-create-ads-account
    @asvinb
    asvinb committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d46d6ca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    50e36fd View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    75c7827 View commit details
    Browse the repository at this point in the history

  2. Address CR feedback.

    @asvinb
    asvinb committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fea64c6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    92fb813 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @joemcgill
    joemcgill committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    01f1097 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5e81fba View commit details
    Browse the repository at this point in the history

  2. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fc6214d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b89142d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4fd8997 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    24a9c4f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bccac35 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    35580cb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @asvinb
    asvinb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3044904 View commit details
    Browse the repository at this point in the history

  6. Address CR feedback.

    @asvinb
    asvinb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d82c8d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Fix ConnectAds props

    @joemcgill
    joemcgill committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    4be14db View commit details
    Browse the repository at this point in the history

  2. Fix E2E tests

    @joemcgill
    joemcgill committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ab319c7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update/2582-claim-ads-account' into update/2603-create-… 

    …ads-account
    @joemcgill
    joemcgill committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a05eb38 View commit details
    Browse the repository at this point in the history

  4. Limit Ads claim updates to 3 retries

    @joemcgill
    joemcgill committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d074504 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Inline docs updates 

    Co-authored-by: Eason <[email protected]>
    @joemcgill @eason9487
    joemcgill and eason9487 authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    51718c2 View commit details
    Browse the repository at this point in the history

  2. Docblock fix

    @joemcgill
    joemcgill committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3492fa5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Update JSDoc.

    @asvinb
    asvinb committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    54448e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/2509-consolidate-google-account-cards' into upd… 

    …ate/2603-create-ads-account
    @joemcgill
    joemcgill committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    55cbeb9 View commit details
    Browse the repository at this point in the history

  3. E2E: Remove flaky mocks from auto account creation test

    @joemcgill
    joemcgill committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f2aa1c9 View commit details
    Browse the repository at this point in the history