Remove the word "Paid" from Ads creation flows #2672

joemcgill · 2024-11-11T23:41:30Z

Changes proposed in this Pull Request:

Closes #2664.

Screenshots:

Detailed test instructions:

Complete onboarding without creating a campaign
Review the CTA in the dashboard for creating a campaign
Create a paid campaign and review the UI when creating a campaign

Additional details:

Changelog entry

Tweak - Remove the word "Paid" associated with campaign creation.

codecov · 2024-11-11T23:44:45Z

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.6%. Comparing base (2c3f089) to head (10dc1c9).
Report is 10 commits behind head on feature/2460-google-ads-value-prop.

Files with missing lines	Patch %	Lines
...src/components/paid-ads/asset-group/asset-group.js	0.0%	1 Missing ⚠️

Additional details and impacted files

@@                        Coverage Diff                         @@
##           feature/2460-google-ads-value-prop   #2672   +/-   ##
==================================================================
  Coverage                                63.6%   63.6%           
==================================================================
  Files                                     332     332           
  Lines                                    5210    5210           
  Branches                                 1265    1265           
==================================================================
  Hits                                     3315    3315           
  Misses                                   1718    1718           
  Partials                                  177     177

Flag	Coverage Δ
js-unit-tests	`63.6% <50.0%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rc/components/paid-ads/add-paid-campaign-button.js	`73.3% <100.0%> (ø)`
...c/components/paid-ads/ads-campaign/ads-campaign.js	`0.0% <ø> (ø)`
...-program-button/edit-program-prompt-modal/index.js	`10.0% <ø> (ø)`
...e-card/program-toggle/pause-program-modal/index.js	`14.3% <ø> (ø)`
...emove-program-button/remove-program-modal/index.js	`7.1% <ø> (ø)`
...dashboard/campaign-creation-success-guide/index.js	`71.4% <ø> (ø)`
js/src/pages/create-paid-ads-campaign/index.js	`10.0% <ø> (ø)`
js/src/pages/edit-paid-ads-campaign/index.js	`8.6% <ø> (ø)`
...src/product-feed/submission-success-guide/index.js	`65.2% <ø> (ø)`
js/src/setup-ads/ads-stepper/index.js	`83.3% <ø> (ø)`
... and 2 more

joemcgill · 2024-11-11T23:45:12Z

This is a quick one to update some UI text based on feedback from @fblascogarma during the review of #2460.

asvinb

LGTM!

mikkamp

Thanks for these changes, I can confirm that those screens now show the updated text.

I noticed that when you click the edit campaign button the following popup is still shown which mentions a paid campaign:

I was also a bit confused about going through the onboarding and creating a campaign. I was expecting to be redirected to the dashboard at the following URL: /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&guide=campaign-creation-success

But instead I was redirected to the product feed tab with the following modal: /wp-admin/admin.php?page=wc-admin&guide=submission-success&path=%2Fgoogle%2Fproduct-feed
Is there another PR where that behaviour was changed intentionally?

For the rest everything looks pretty good, just a few small minor comments about renaming some additional test lines.

I wasn't able to confirm the E2E tests are still passing as it fails with a missing currency in the text. I don't see that being directly related to this PR, but possibly some of the dependent code changed this.

  1) [chromium] › setup-mc/step-4-complete-campaign.test.js:259:5 › Complete your campaign › Set up paid ads › Set up a campaign › Validate budget percent › should see validation error if lower than the 30% 

    Error: Timed out 20000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.components-base-control__help')
    Expected string: "Please make sure daily average cost is at least NT$30.00"
    Received string: "Please make sure daily average cost is at least 30.00"

src/Tracking/README.md

mikkamp · 2024-11-12T16:19:22Z

tests/e2e/specs/add-paid-campaigns/add-paid-campaigns.test.js

@@ -280,13 +280,13 @@ test.describe( 'Set up Ads account', () => {
 		} );
 	} );

-	test.describe( 'Create your paid campaign', () => {
+	test.describe( 'Create your campaign', () => {
 		test( 'Continue to create paid ad campaign', async () => {


Since other test descriptions are being updated, we can change this one as well.

Addressed in 4ac7c89

Co-authored-by: Mik <[email protected]>

joemcgill · 2024-11-12T18:48:03Z

Thanks @mikkamp. I've addressed the two inline suggestions. For your other observations:

I noticed that when you click the edit campaign button the following popup is still shown which mentions a paid campaign:

Good catch. I'm not sure if we want to update the copy for these as well. I'll confirm with @fblascogarma.

I was also a bit confused about going through the onboarding and creating a campaign. I was expecting to be redirected to the dashboard at the following URL

The onboarding flow has ended with the user redirected to the Product Feed tab since at least this commit, so I assume that has been an intentional decision.

I wasn't able to confirm the E2E tests are still passing as it fails with a missing currency in the text. I don't see that being directly related to this PR, but possibly some of the dependent code changed this.

I'm unable to reproduce this E2E test failure. Just to be safe, I triggered another full test run here, which seems to be passing.

eason9487

There are other places that may not be within the campaign creation scope, but have the word "paid", which could be further confirmed.

Get Started

Dashboard

Edit Campaign

Can be found with path /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard&subpath=%2Fcampaigns%2Fedit&programId=0

Reports

Reports > Products

Settings

Inbox notifications

fblascogarma · 2024-11-14T17:56:48Z

Good catch @eason9487 ! Yes, please let's remove it from those places too. Thank you!!

joemcgill · 2024-11-14T19:07:29Z

The additional instances of 'paid' have been replaced in the last two commits.

In each case, I've tried to use my best judgement in when it was appropriate to replace the existing text with "Google Ads", "campaign(s)", based on the context in which they are found.

For example, in the EditProgramPromptModal that is shown when editing both Free listings and Google Ads, the existing text was (emphasis mine) "Results typically improve with time with Google’s Free Listing and paid ad campaigns". I've chosen to replace this with "Results typically improve with time with Google’s Free Listing and Google Ads campaigns" to avoid implying that Ad campaigns are also free.

@fblascogarma feel free to review all the changes and suggest any additional tweaks.

eason9487

There are still a few left over but it shouldn't be a need for another round.

google-listings-and-ads/js/src/setup-mc/setup-stepper/skip-button.js

Line 68 in cef1b83

'Skip paid ads creation',

google-listings-and-ads/tests/e2e/utils/pages/setup-mc/step-4-complete-campaign.js

Line 77 in cef1b83

name: 'Skip paid ads creation',

eason9487 · 2024-11-15T10:05:42Z

src/Notes/SetupCampaignTwoWeeks.php

@@ -48,7 +48,7 @@ protected function set_title_and_content( NoteEntry $note ): void {
 			$note->set_title( __( 'Reach more shoppers with paid listings on Google', 'google-listings-and-ads' ) );


The title has the word "paid" as well.

joemcgill · 2024-11-17T22:17:00Z

Updated based on feedback in #2672 (review) and this edit from @fblascogarma.

Cherry-picked a70da30 in order to E2E Tests and it looks like everything is passing, except for a known issue fixed in #2670.

Remove 'Paid' from ads creation

d38b1ec

github-actions bot added the changelog: update Big changes to something that wasn't broken. label Nov 11, 2024

joemcgill changed the base branch from develop to feature/2460-google-ads-value-prop November 11, 2024 23:42

joemcgill requested review from eason9487 and asvinb and removed request for eason9487 November 11, 2024 23:42

joemcgill marked this pull request as ready for review November 11, 2024 23:43

asvinb approved these changes Nov 12, 2024

View reviewed changes

mikkamp reviewed Nov 12, 2024

View reviewed changes

joemcgill and others added 2 commits November 12, 2024 11:42

Update E2E test description

4ac7c89

Update src/Tracking/README.md

3a36464

Co-authored-by: Mik <[email protected]>

eason9487 reviewed Nov 13, 2024

View reviewed changes

eason9487 added changelog: tweak Small change, that isn't actually very important. and removed changelog: update Big changes to something that wasn't broken. labels Nov 13, 2024

joemcgill added 2 commits November 14, 2024 12:49

Remove additional instances of the word 'paid' with Ads

fa1f5ed

Copy tweak

cef1b83

eason9487 approved these changes Nov 15, 2024

View reviewed changes

joemcgill and others added 4 commits November 17, 2024 15:36

Results typically improve with time

9b71ea6

Skip ads creation

933e5b4

Fix the issue that E2E test can't log in to wp-admin.

a70da30

Reach more shoppers with Google Ads

10dc1c9

joemcgill merged commit 98c62a5 into feature/2460-google-ads-value-prop Nov 17, 2024
9 of 13 checks passed

joemcgill deleted the update/2664-remove-paid-word branch November 17, 2024 22:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the word "Paid" from Ads creation flows #2672

Remove the word "Paid" from Ads creation flows #2672

joemcgill commented Nov 11, 2024 •

edited by eason9487

Loading

codecov bot commented Nov 11, 2024 •

edited

Loading

joemcgill commented Nov 11, 2024

asvinb left a comment

mikkamp left a comment •

edited

Loading

mikkamp Nov 12, 2024

joemcgill Nov 12, 2024

joemcgill commented Nov 12, 2024

eason9487 left a comment •

edited

Loading

fblascogarma commented Nov 14, 2024

joemcgill commented Nov 14, 2024

eason9487 left a comment

eason9487 Nov 15, 2024

joemcgill commented Nov 17, 2024

		@@ -48,7 +48,7 @@ protected function set_title_and_content( NoteEntry $note ): void {
		$note->set_title( __( 'Reach more shoppers with paid listings on Google', 'google-listings-and-ads' ) );

Remove the word "Paid" from Ads creation flows #2672

Remove the word "Paid" from Ads creation flows #2672

Conversation

joemcgill commented Nov 11, 2024 • edited by eason9487 Loading

Changes proposed in this Pull Request:

Screenshots:

Detailed test instructions:

Additional details:

Changelog entry

codecov bot commented Nov 11, 2024 • edited Loading

Codecov Report

joemcgill commented Nov 11, 2024

asvinb left a comment

Choose a reason for hiding this comment

mikkamp left a comment • edited Loading

Choose a reason for hiding this comment

mikkamp Nov 12, 2024

Choose a reason for hiding this comment

joemcgill Nov 12, 2024

Choose a reason for hiding this comment

joemcgill commented Nov 12, 2024

eason9487 left a comment • edited Loading

Choose a reason for hiding this comment

Get Started

Dashboard

Edit Campaign

Reports

Reports > Products

Settings

Inbox notifications

fblascogarma commented Nov 14, 2024

joemcgill commented Nov 14, 2024

eason9487 left a comment

Choose a reason for hiding this comment

eason9487 Nov 15, 2024

Choose a reason for hiding this comment

joemcgill commented Nov 17, 2024

joemcgill commented Nov 11, 2024 •

edited by eason9487

Loading

codecov bot commented Nov 11, 2024 •

edited

Loading

mikkamp left a comment •

edited

Loading

eason9487 left a comment •

edited

Loading