Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the QIT Woo E2E tests and add new PHPCompat and Malware tests. #452

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

iamdharmesh
Copy link
Member

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

PR makes the following changes.

  • Fix the QIT API and Woo E2E tests (by updating the run:api command to run:woo-api and run:e2e command to run:woo-e2e )
  • Adds new commands to run PHPCompat and Malware tests
  • Updates some actions.

Closes #444

Steps to test the changes in this Pull Request:

Try adding the following labels to this PR to ensure tests run:

  • needs: qit api test
  • needs: qit e2e test
  • needs: qit phpcompat test
  • needs: qit malware test

Changelog entry

Dev - Fix QIT E2E tests and add support for a few new test types.

@vikrampm1 vikrampm1 modified the milestones: Future Release, 1.2.8 Aug 2, 2024
@vikrampm1 vikrampm1 marked this pull request as ready for review August 2, 2024 14:13
@vikrampm1
Copy link
Contributor

@dkotter is it good to proceed with merging the PR as I see failed E2E tests here?

@dkotter
Copy link
Contributor

dkotter commented Aug 2, 2024

@dkotter is it good to proceed with merging the PR as I see failed E2E tests here?

Yes. No changes were made here that would impact those tests so those failures are either flaky tests are failures introduced elsewhere. If those are legitimate failures, we'll want to fix those when we prep the release PR

@vikrampm1 vikrampm1 merged commit 8a643cd into trunk Aug 2, 2024
8 of 9 checks passed
@vikrampm1 vikrampm1 deleted the fix/444 branch August 2, 2024 14:21
@vikrampm1 vikrampm1 mentioned this pull request Aug 16, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some QIT tests aren't running properly
3 participants