Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.8 #457

Merged
merged 8 commits into from
Aug 28, 2024
Merged

Release/1.2.8 #457

merged 8 commits into from
Aug 28, 2024

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Aug 16, 2024

Changes proposed in this Pull Request:

Version bump and prep for the 1.2.8 release

Closes #456

Steps to test the changes in this Pull Request:

Verify all file changes look accurate

@dkotter
Copy link
Contributor Author

dkotter commented Aug 16, 2024

E2E tests are failing here. Will need to look at those before we proceed

@axi
Copy link

axi commented Aug 22, 2024

switchTab() method search for the last '.wc-tabs > li > a' with name "Availability" but it's now the #bookings_availability that is listed last in the code (and hidden) so test script cannot click it.

<li class="accommodation_bookings_availability_options accommodation_bookings_availability_tab show_if_accommodation-booking accommodation_bookings_tab bookings_availability_tab advanced_options">
    <a href="#accommodation_bookings_availability]"><span>Availability</span></a>
</li>
<li class="bookings_resources_options bookings_resources_tab show_if_booking">
    <a href="#bookings_resources"><span>Resources</span></a>
</li>
<li class="bookings_availability_options bookings_availability_tab show_if_booking">
    <a href="#bookings_availability"><span>Availability</span></a>
</li>

Modifying the selector looks to work : '.wc-tabs > li > a' => '.wc-tabs > li:visible > a'
in tests/e2e/utils/index.js

/**
 * Switch tab in add/edit product page.
 *
 * @param {Page}   page          Playwright page object
 * @param {string} tabName       Tab name
 * @param {string} panelSelector Options Panel selector
 */
export async function switchTab(page, tabName, panelSelector = false) {
	await page
		.locator('.wc-tabs > li:visible > a', { hasText: tabName })
		.last()
		.click();
	if (panelSelector) {
		await expect(page.locator(panelSelector)).toBeVisible();
	}
}

@axi
Copy link

axi commented Aug 27, 2024

E2E tests went through on my machine with the last commit

@iamdharmesh
Copy link
Member

Thanks a lot for the suggestion @axi. It worked.

E2E tests went through on my machine with the last commit

Yes, it was working fine for me as well. I have fixed it now. Thanks.

@dkotter we are ready for the next steps here.

changelog.txt Outdated Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
@dkotter dkotter merged commit c0b6e76 into trunk Aug 28, 2024
6 checks passed
@dkotter dkotter deleted the release/1.2.8 branch August 28, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version 1.2.8
4 participants