-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.2.8 #457
Release/1.2.8 #457
Conversation
E2E tests are failing here. Will need to look at those before we proceed |
Modifying the selector looks to work : /**
* Switch tab in add/edit product page.
*
* @param {Page} page Playwright page object
* @param {string} tabName Tab name
* @param {string} panelSelector Options Panel selector
*/
export async function switchTab(page, tabName, panelSelector = false) {
await page
.locator('.wc-tabs > li:visible > a', { hasText: tabName })
.last()
.click();
if (panelSelector) {
await expect(page.locator(panelSelector)).toBeVisible();
}
} |
E2E tests went through on my machine with the last commit |
Thanks a lot for the suggestion @axi. It worked.
Yes, it was working fine for me as well. I have fixed it now. Thanks. @dkotter we are ready for the next steps here. |
Changes proposed in this Pull Request:
Version bump and prep for the 1.2.8 release
Closes #456
Steps to test the changes in this Pull Request:
Verify all file changes look accurate