Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix price sorting by fixing product_meta_lookup min_price & max_price #460

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

axi
Copy link

@axi axi commented Aug 28, 2024

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Update the min_price & max_price values in wc_product_meta_lookup that has been wrongly set to unique cost times duration by the booking data store.

Closes #434 .

Steps to test the changes in this Pull Request:

Check the "Steps to reproduce the issue" in #434 issue

Changelog entry

Fix - Price sorting.

@vikrampm1 vikrampm1 added this to the Future Release milestone Sep 3, 2024
@ankitguptaindia ankitguptaindia marked this pull request as draft September 5, 2024 15:57
@axi
Copy link
Author

axi commented Sep 9, 2024

Hi @ankitguptaindia, what means the draft status ? Does it need something on my side ?

@ankitguptaindia
Copy link
Member

@axi This is our part of the process. we keep PR status in draft until we complete our QA/UAT processes so nothing from your side until we find anything in QA/UAT.

@axi
Copy link
Author

axi commented Nov 8, 2024

Any news on that PR ?

@vikrampm1
Copy link
Contributor

@ankitguptaindia @Sourabh208 This PR is awaiting QA, please prioritize it in your queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price for sorting is incorrect
4 participants