Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for shipping label support #12617

Merged
merged 12 commits into from
Oct 16, 2024
Merged

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Sep 16, 2024

Part of: #12444

Description

This PR introduces the ShippingLabelSupport enum to give us more control over the shipping label flow. With the changes introduced here, we can check if an order supports purchasing shipping labels and whether we should use the new or legacy flow.

Testing information

TC1

  1. Install & Activate the WCS&T plugin on your store
  2. Check that the purchase shipping label flow keeps working as expected

TC2

  1. Install & Activate the WCS plugin on your store
  2. Check that the purchase shipping label flow keeps working as expected

The tests that have been performed

  1. Tested that the purchase shipping label flow keeps working as expected using the WCS&T and the WCS plugins
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Sep 16, 2024

1 Warning
⚠️ This PR is assigned to the milestone 20.9. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit5746370
Direct Downloadwoocommerce-wear-prototype-build-pr12617-5746370.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit5746370
Direct Downloadwoocommerce-prototype-build-pr12617-5746370.apk

@atorresveiga atorresveiga changed the title check for plugin version Check for plugin version Oct 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (fa9bb72) to head (5746370).
Report is 13 commits behind head on trunk.

Files with missing lines Patch % Lines
...rders/details/ShippingLabelOnboardingRepository.kt 73.68% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12617   +/-   ##
=========================================
  Coverage     40.84%   40.84%           
+ Complexity     5755     5751    -4     
=========================================
  Files          1237     1237           
  Lines         69742    69751    +9     
  Branches       9680     9685    +5     
=========================================
+ Hits          28484    28490    +6     
- Misses        38634    38635    +1     
- Partials       2624     2626    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga changed the title Check for plugin version Check for shipping label support Oct 4, 2024
@atorresveiga atorresveiga marked this pull request as ready for review October 16, 2024 18:04
@atorresveiga atorresveiga added feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task. labels Oct 16, 2024
@atorresveiga atorresveiga added this to the 20.9 milestone Oct 16, 2024
@atorresveiga atorresveiga merged commit 72ef9a3 into trunk Oct 16, 2024
16 of 18 checks passed
@atorresveiga atorresveiga deleted the issue/12444-entry-point-new-sl-flow branch October 16, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants