Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile Payments] Remove duplicate back button from the Try Tap to Pay customer provided note screen #12787

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

AnirudhBhat
Copy link
Contributor

@AnirudhBhat AnirudhBhat commented Oct 16, 2024

Closes: #12778

Description

This PR removes duplicate back button that appeared on the Try Tap to Pay customer provided note screen.

Steps to reproduce

  1. Navigate to the payments hub menu (more menu -> Payments)'
  2. Click on "Try Tap to Pay" option
  3. Click on "Try payment" option
  4. In this screen, try editing the customer provided note
  5. Observe the duplicate back arrow button

The tests that have been performed

Tested on both dark and light mode, tested adding notes, removing notes.

Images/gif

duplicate_back_button_ttp_note.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@AnirudhBhat AnirudhBhat added type: bug A confirmed bug. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Oct 16, 2024
@AnirudhBhat AnirudhBhat added this to the 20.8 milestone Oct 16, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit2b06f3b
Direct Downloadwoocommerce-wear-prototype-build-pr12787-2b06f3b.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit2b06f3b
Direct Downloadwoocommerce-prototype-build-pr12787-2b06f3b.apk

Copy link
Collaborator

@samiuelson samiuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving that @AnirudhBhat! I added a small suggestion—let me know what you think.

import org.wordpress.android.util.ActivityUtils
import org.wordpress.android.util.DisplayUtils

class SimplePaymentsCustomerNoteFragment :
BaseFragment(R.layout.fragment_order_create_edit_customer_note),
MenuProvider {
BaseFragment(R.layout.fragment_order_create_edit_customer_note) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 I think we are not using any functionality provided by BaseFragment, so I suggest switching to the plain Fragment class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using override val activityAppBarStatus: AppBarStatus get() = AppBarStatus.Hidden from BaseFragment to hide the default toolbar and use our own. I think using plain Fragment would again cause multiple toolbar (one from our own custom toolbar and another that exist from previous screen)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you're right 👍🏼

Base automatically changed from issue/12729-fix-pay-in-person-learn-more-link to trunk October 17, 2024 20:29
@AnirudhBhat AnirudhBhat modified the milestones: 20.8, 20.9 Oct 18, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 20.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@samiuelson samiuelson merged commit ebbf4bc into trunk Oct 18, 2024
17 of 20 checks passed
@samiuelson samiuelson deleted the issue/12778-duplicate-back-button-ttp branch October 18, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile Payments]Duplicate back arrow when editing default "customer provided note" when trying Tap to Pay
4 participants